Return-Path: Delivered-To: apmail-commons-commits-archive@minotaur.apache.org Received: (qmail 19658 invoked from network); 23 Oct 2010 22:11:49 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 23 Oct 2010 22:11:49 -0000 Received: (qmail 85402 invoked by uid 500); 23 Oct 2010 22:11:49 -0000 Delivered-To: apmail-commons-commits-archive@commons.apache.org Received: (qmail 85353 invoked by uid 500); 23 Oct 2010 22:11:49 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 85345 invoked by uid 99); 23 Oct 2010 22:11:49 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 23 Oct 2010 22:11:49 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 23 Oct 2010 22:11:47 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id A18CE23888FD; Sat, 23 Oct 2010 22:10:50 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1026698 - /commons/proper/email/trunk/src/java/org/apache/commons/mail/Email.java Date: Sat, 23 Oct 2010 22:10:50 -0000 To: commits@commons.apache.org From: sgoeschl@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20101023221050.A18CE23888FD@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: sgoeschl Date: Sat Oct 23 22:10:50 2010 New Revision: 1026698 URL: http://svn.apache.org/viewvc?rev=1026698&view=rev Log: [EMAIL-76] Forget one setter which was not returning the 'this' instance. Modified: commons/proper/email/trunk/src/java/org/apache/commons/mail/Email.java Modified: commons/proper/email/trunk/src/java/org/apache/commons/mail/Email.java URL: http://svn.apache.org/viewvc/commons/proper/email/trunk/src/java/org/apache/commons/mail/Email.java?rev=1026698&r1=1026697&r2=1026698&view=diff ============================================================================== --- commons/proper/email/trunk/src/java/org/apache/commons/mail/Email.java (original) +++ commons/proper/email/trunk/src/java/org/apache/commons/mail/Email.java Sat Oct 23 22:10:50 2010 @@ -195,10 +195,10 @@ public abstract class Email implements E * @see #setAuthenticator * @since 1.0 */ - public void setAuthentication(String userName, String password) + public Email setAuthentication(String userName, String password) { this.authenticator = new DefaultAuthenticator(userName, password); - this.setAuthenticator(this.authenticator); + return this.setAuthenticator(this.authenticator); } /** @@ -213,9 +213,10 @@ public abstract class Email implements E * @see Authenticator * @since 1.0 */ - public void setAuthenticator(Authenticator newAuthenticator) + public Email setAuthenticator(Authenticator newAuthenticator) { this.authenticator = newAuthenticator; + return this; } /** @@ -1482,7 +1483,6 @@ public abstract class Email implements E * Get the socket I/O timeout value in milliseconds. * * @return the socket I/O timeout - * @return An Email. * @since 1.2 */ public int getSocketTimeout()