From commits-return-14218-apmail-commons-commits-archive=commons.apache.org@commons.apache.org Tue Oct 12 16:58:22 2010 Return-Path: Delivered-To: apmail-commons-commits-archive@minotaur.apache.org Received: (qmail 38838 invoked from network); 12 Oct 2010 16:58:21 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 12 Oct 2010 16:58:21 -0000 Received: (qmail 45227 invoked by uid 500); 12 Oct 2010 16:58:21 -0000 Delivered-To: apmail-commons-commits-archive@commons.apache.org Received: (qmail 45176 invoked by uid 500); 12 Oct 2010 16:58:21 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 45169 invoked by uid 99); 12 Oct 2010 16:58:21 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Oct 2010 16:58:21 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Oct 2010 16:58:20 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id CFD9623889E9; Tue, 12 Oct 2010 16:58:00 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1021833 - /commons/proper/pool/trunk/src/java/org/apache/commons/pool/PoolUtils.java Date: Tue, 12 Oct 2010 16:58:00 -0000 To: commits@commons.apache.org From: ggregory@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20101012165800.CFD9623889E9@eris.apache.org> Author: ggregory Date: Tue Oct 12 16:58:00 2010 New Revision: 1021833 URL: http://svn.apache.org/viewvc?rev=1021833&view=rev Log: Use Java 5's enhanced for loops (with Generics) Modified: commons/proper/pool/trunk/src/java/org/apache/commons/pool/PoolUtils.java Modified: commons/proper/pool/trunk/src/java/org/apache/commons/pool/PoolUtils.java URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/java/org/apache/commons/pool/PoolUtils.java?rev=1021833&r1=1021832&r2=1021833&view=diff ============================================================================== --- commons/proper/pool/trunk/src/java/org/apache/commons/pool/PoolUtils.java (original) +++ commons/proper/pool/trunk/src/java/org/apache/commons/pool/PoolUtils.java Tue Oct 12 16:58:00 2010 @@ -271,12 +271,9 @@ public final class PoolUtils { throw new IllegalArgumentException("keys must not be null."); } final Map tasks = new HashMap(keys.size()); - final Iterator iter = keys.iterator(); - while (iter.hasNext()) { - final K key = iter.next(); - final TimerTask task = checkMinIdle(keyedPool, key, minIdle, period); - tasks.put(key, task); - } + for (K key : keys) { + tasks.put(key, checkMinIdle(keyedPool, key, minIdle, period)); + } return tasks; } @@ -339,9 +336,8 @@ public final class PoolUtils { if (keys == null) { throw new IllegalArgumentException("keys must not be null."); } - final Iterator iter = keys.iterator(); - while (iter.hasNext()) { - prefill(keyedPool, iter.next(), count); + for (K key : keys) { + prefill(keyedPool, key, count); } }