commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject svn commit: r1024085 - /commons/proper/collections/trunk/src/java/org/apache/commons/collections/comparators/NullComparator.java
Date Tue, 19 Oct 2010 01:39:13 GMT
Author: sebb
Date: Tue Oct 19 01:39:13 2010
New Revision: 1024085

URL: http://svn.apache.org/viewvc?rev=1024085&view=rev
Log:
private immutable fields might as well be final

Modified:
    commons/proper/collections/trunk/src/java/org/apache/commons/collections/comparators/NullComparator.java

Modified: commons/proper/collections/trunk/src/java/org/apache/commons/collections/comparators/NullComparator.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/java/org/apache/commons/collections/comparators/NullComparator.java?rev=1024085&r1=1024084&r2=1024085&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/java/org/apache/commons/collections/comparators/NullComparator.java
(original)
+++ commons/proper/collections/trunk/src/java/org/apache/commons/collections/comparators/NullComparator.java
Tue Oct 19 01:39:13 2010
@@ -38,13 +38,13 @@ public class NullComparator<E> implement
     /**
      *  The comparator to use when comparing two non-<code>null</code> objects.
      **/
-    private Comparator<E> nonNullComparator;
+    private final Comparator<E> nonNullComparator;
 
     /**
      *  Specifies whether a <code>null</code> are compared as higher than
      *  non-<code>null</code> objects.
      **/
-    private boolean nullsAreHigh;
+    private final boolean nullsAreHigh;
 
     //-----------------------------------------------------------------------
     /**



Mime
View raw message