commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sgoes...@apache.org
Subject svn commit: r1023092 - in /commons/proper/email/trunk/src: changes/changes.xml java/org/apache/commons/mail/Email.java
Date Fri, 15 Oct 2010 20:01:39 GMT
Author: sgoeschl
Date: Fri Oct 15 20:01:39 2010
New Revision: 1023092

URL: http://svn.apache.org/viewvc?rev=1023092&view=rev
Log:
[EMAIL-100] The default connection timeout should be set to a reasonable default value

Modified:
    commons/proper/email/trunk/src/changes/changes.xml
    commons/proper/email/trunk/src/java/org/apache/commons/mail/Email.java

Modified: commons/proper/email/trunk/src/changes/changes.xml
URL: http://svn.apache.org/viewvc/commons/proper/email/trunk/src/changes/changes.xml?rev=1023092&r1=1023091&r2=1023092&view=diff
==============================================================================
--- commons/proper/email/trunk/src/changes/changes.xml (original)
+++ commons/proper/email/trunk/src/changes/changes.xml Fri Oct 15 20:01:39 2010
@@ -23,6 +23,9 @@
 
   <body>
     <release version="1.3-SNAPSHOT" date="as in SVN">
+      <action dev="sgoeschl" type="fix" issue="EMAIL-100" date="2010-10-15" due-to="David
Parks">
+        The default connection timeout is set to a reasonable default value of 60 seconds.
+      </action>
       <action dev="sgoeschl" type="fix" date="2010-10-15">
         Moving the various constants from 'EMail' to 'EmailConstants'
       </action>

Modified: commons/proper/email/trunk/src/java/org/apache/commons/mail/Email.java
URL: http://svn.apache.org/viewvc/commons/proper/email/trunk/src/java/org/apache/commons/mail/Email.java?rev=1023092&r1=1023091&r2=1023092&view=diff
==============================================================================
--- commons/proper/email/trunk/src/java/org/apache/commons/mail/Email.java (original)
+++ commons/proper/email/trunk/src/java/org/apache/commons/mail/Email.java Fri Oct 15 20:01:39
2010
@@ -159,9 +159,10 @@ public abstract class Email implements E
     protected boolean ssl;
 
     /** socket I/O timeout value in milliseconds */
-    protected int socketTimeout;
+    protected int socketTimeout = 60000;
+    
     /** socket connection timeout value in milliseconds */
-    protected int socketConnectionTimeout;
+    protected int socketConnectionTimeout = 60000;
 
     /** The Session to mail with */
     private Session session;
@@ -207,7 +208,7 @@ public abstract class Email implements E
      * authentication.  Your mail server must also support RFC2554.
      *
      * @param newAuthenticator the <code>Authenticator</code> object.
-     * @return An Email.
+     * @return Email.
      * @see Authenticator
      * @since 1.0
      */



Mime
View raw message