Return-Path: Delivered-To: apmail-commons-commits-archive@minotaur.apache.org Received: (qmail 20707 invoked from network); 30 Jul 2010 19:00:30 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 30 Jul 2010 19:00:30 -0000 Received: (qmail 80512 invoked by uid 500); 30 Jul 2010 19:00:30 -0000 Delivered-To: apmail-commons-commits-archive@commons.apache.org Received: (qmail 80430 invoked by uid 500); 30 Jul 2010 19:00:29 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 80420 invoked by uid 99); 30 Jul 2010 19:00:29 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Jul 2010 19:00:29 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Jul 2010 19:00:26 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 7474023889E7; Fri, 30 Jul 2010 18:59:09 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r980923 - /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/EqualsBuilder.java Date: Fri, 30 Jul 2010 18:59:09 -0000 To: commits@commons.apache.org From: mbenson@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20100730185909.7474023889E7@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: mbenson Date: Fri Jul 30 18:59:09 2010 New Revision: 980923 URL: http://svn.apache.org/viewvc?rev=980923&view=rev Log: use static method for brevity, avoiding type params Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/EqualsBuilder.java Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/EqualsBuilder.java URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/EqualsBuilder.java?rev=980923&r1=980922&r2=980923&view=diff ============================================================================== --- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/EqualsBuilder.java (original) +++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/EqualsBuilder.java Fri Jul 30 18:59:09 2010 @@ -140,7 +140,7 @@ public class EqualsBuilder implements Bu static Pair getRegisterPair(Object lhs, Object rhs) { IDKey left = new IDKey(lhs); IDKey right = new IDKey(rhs); - return new Pair(left, right); + return Pair.of(left, right); } /** @@ -159,8 +159,7 @@ public class EqualsBuilder implements Bu static boolean isRegistered(Object lhs, Object rhs) { Set> registry = getRegistry(); Pair pair = getRegisterPair(lhs, rhs); - Pair swappedPair = new Pair(pair.right, - pair.left); + Pair swappedPair = Pair.of(pair.right, pair.left); return registry != null && (registry.contains(pair) || registry.contains(swappedPair));