commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ebo...@apache.org
Subject svn commit: r961361 - /commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/HelpFormatter.java
Date Wed, 07 Jul 2010 12:55:19 GMT
Author: ebourg
Date: Wed Jul  7 12:55:18 2010
New Revision: 961361

URL: http://svn.apache.org/viewvc?rev=961361&view=rev
Log:
Simplified the createPadding() method

Modified:
    commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/HelpFormatter.java

Modified: commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/HelpFormatter.java
URL: http://svn.apache.org/viewvc/commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/HelpFormatter.java?rev=961361&r1=961360&r2=961361&view=diff
==============================================================================
--- commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/HelpFormatter.java (original)
+++ commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/HelpFormatter.java Wed Jul
 7 12:55:18 2010
@@ -19,6 +19,7 @@ package org.apache.commons.cli;
 
 import java.io.PrintWriter;
 import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.Collection;
 import java.util.Collections;
 import java.util.Comparator;
@@ -860,8 +861,7 @@ public class HelpFormatter
             nextLineTabStop = 1;
         }
 
-        // all following lines must be padded with nextLineTabStop space 
-        // characters
+        // all following lines must be padded with nextLineTabStop space characters
         final String padding = createPadding(nextLineTabStop);
 
         while (true)
@@ -888,7 +888,7 @@ public class HelpFormatter
     /**
      * Finds the next text wrap position after <code>startPos</code> for the
      * text in <code>text</code> with the column width <code>width</code>.
-     * The wrap point is the last postion before startPos+width having a 
+     * The wrap point is the last position before startPos+width having a 
      * whitespace character (space, \n, \r).
      *
      * @param text The text being searched for the wrap position
@@ -953,14 +953,10 @@ public class HelpFormatter
      */
     protected String createPadding(int len)
     {
-        StringBuffer sb = new StringBuffer(len);
-
-        for (int i = 0; i < len; ++i)
-        {
-            sb.append(' ');
-        }
-
-        return sb.toString();
+        char[] padding = new char[len];
+        Arrays.fill(padding, ' ');
+        
+        return new String(padding);
     }
 
     /**



Mime
View raw message