Return-Path: Delivered-To: apmail-commons-commits-archive@minotaur.apache.org Received: (qmail 63211 invoked from network); 28 May 2010 16:30:39 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 28 May 2010 16:30:39 -0000 Received: (qmail 25711 invoked by uid 500); 28 May 2010 16:30:38 -0000 Delivered-To: apmail-commons-commits-archive@commons.apache.org Received: (qmail 25619 invoked by uid 500); 28 May 2010 16:30:38 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 25612 invoked by uid 99); 28 May 2010 16:30:37 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 May 2010 16:30:37 +0000 X-ASF-Spam-Status: No, hits=-1933.4 required=10.0 tests=ALL_TRUSTED,AWL X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 May 2010 16:30:37 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id CCD0823889EA; Fri, 28 May 2010 16:30:16 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r949222 - /commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/SystemUtilsTest.java Date: Fri, 28 May 2010 16:30:16 -0000 To: commits@commons.apache.org From: ggregory@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20100528163016.CCD0823889EA@eris.apache.org> Author: ggregory Date: Fri May 28 16:30:16 2010 New Revision: 949222 URL: http://svn.apache.org/viewvc?rev=949222&view=rev Log: (LANG-624) SystemUtils.getJavaVersionAsFloat throws StringIndexOutOfBoundsException on Android runtime/Dalvik VM. More assertions. Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/SystemUtilsTest.java Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/SystemUtilsTest.java URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/SystemUtilsTest.java?rev=949222&r1=949221&r2=949222&view=diff ============================================================================== --- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/SystemUtilsTest.java (original) +++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/SystemUtilsTest.java Fri May 28 16:30:16 2010 @@ -201,6 +201,7 @@ public class SystemUtilsTest extends Tes assertEquals(1.5f, SystemUtils.toJavaVersionFloat("1.5.0"), 0.000001f); assertEquals(1.6f, SystemUtils.toJavaVersionFloat("1.6.0"), 0.000001f); assertEquals(1.31f, SystemUtils.toJavaVersionFloat("JavaVM-1.3.1"), 0.000001f); + assertEquals(1.3f, SystemUtils.toJavaVersionFloat("1.3.0 subset"), 0.000001f); // This used to return 0f in [lang] version 2.5: assertEquals(1.3f, SystemUtils.toJavaVersionFloat("XXX-1.3.x"), 0.000001f); } @@ -219,6 +220,7 @@ public class SystemUtilsTest extends Tes assertEquals(150, SystemUtils.toJavaVersionInt("1.5.0"), 0.000001f); assertEquals(160, SystemUtils.toJavaVersionInt("1.6.0"), 0.000001f); assertEquals(131, SystemUtils.toJavaVersionInt("JavaVM-1.3.1"), 0.000001f); + assertEquals(131, SystemUtils.toJavaVersionInt("1.3.1 subset"), 0.000001f); // This used to return 0f in [lang] version 2.5: assertEquals(130, SystemUtils.toJavaVersionInt("XXX-1.3.x"), 0.000001f); }