Return-Path: Delivered-To: apmail-commons-commits-archive@minotaur.apache.org Received: (qmail 83560 invoked from network); 12 Mar 2010 18:48:22 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 12 Mar 2010 18:48:22 -0000 Received: (qmail 62022 invoked by uid 500); 12 Mar 2010 18:47:44 -0000 Delivered-To: apmail-commons-commits-archive@commons.apache.org Received: (qmail 61964 invoked by uid 500); 12 Mar 2010 18:47:44 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 61957 invoked by uid 99); 12 Mar 2010 18:47:44 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Mar 2010 18:47:44 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Mar 2010 18:47:43 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 5374F238897A; Fri, 12 Mar 2010 18:47:23 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r922388 - in /commons/proper/sanselan/trunk/src/main/java/org/apache/sanselan: common/RationalNumber.java formats/pnm/WhiteSpaceReader.java formats/tiff/photometricinterpreters/PhotometricInterpreterLogLUV.java Date: Fri, 12 Mar 2010 18:47:23 -0000 To: commits@commons.apache.org From: sebb@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20100312184723.5374F238897A@eris.apache.org> Author: sebb Date: Fri Mar 12 18:47:22 2010 New Revision: 922388 URL: http://svn.apache.org/viewvc?rev=922388&view=rev Log: Unnecessary casts Modified: commons/proper/sanselan/trunk/src/main/java/org/apache/sanselan/common/RationalNumber.java commons/proper/sanselan/trunk/src/main/java/org/apache/sanselan/formats/pnm/WhiteSpaceReader.java commons/proper/sanselan/trunk/src/main/java/org/apache/sanselan/formats/tiff/photometricinterpreters/PhotometricInterpreterLogLUV.java Modified: commons/proper/sanselan/trunk/src/main/java/org/apache/sanselan/common/RationalNumber.java URL: http://svn.apache.org/viewvc/commons/proper/sanselan/trunk/src/main/java/org/apache/sanselan/common/RationalNumber.java?rev=922388&r1=922387&r2=922388&view=diff ============================================================================== --- commons/proper/sanselan/trunk/src/main/java/org/apache/sanselan/common/RationalNumber.java (original) +++ commons/proper/sanselan/trunk/src/main/java/org/apache/sanselan/common/RationalNumber.java Fri Mar 12 18:47:22 2010 @@ -91,7 +91,7 @@ public class RationalNumber extends Numb public int intValue() { - return (int) numerator / (int) divisor; + return numerator / divisor; } public long longValue() Modified: commons/proper/sanselan/trunk/src/main/java/org/apache/sanselan/formats/pnm/WhiteSpaceReader.java URL: http://svn.apache.org/viewvc/commons/proper/sanselan/trunk/src/main/java/org/apache/sanselan/formats/pnm/WhiteSpaceReader.java?rev=922388&r1=922387&r2=922388&view=diff ============================================================================== --- commons/proper/sanselan/trunk/src/main/java/org/apache/sanselan/formats/pnm/WhiteSpaceReader.java (original) +++ commons/proper/sanselan/trunk/src/main/java/org/apache/sanselan/formats/pnm/WhiteSpaceReader.java Fri Mar 12 18:47:22 2010 @@ -40,13 +40,13 @@ class WhiteSpaceReader public char nextChar() throws IOException { - char c = (char) read(); + char c = read(); if (c == '#') { while ((c != '\n') && (c != '\r')) { - c = (char) read(); + c = read(); } } return c; Modified: commons/proper/sanselan/trunk/src/main/java/org/apache/sanselan/formats/tiff/photometricinterpreters/PhotometricInterpreterLogLUV.java URL: http://svn.apache.org/viewvc/commons/proper/sanselan/trunk/src/main/java/org/apache/sanselan/formats/tiff/photometricinterpreters/PhotometricInterpreterLogLUV.java?rev=922388&r1=922387&r2=922388&view=diff ============================================================================== --- commons/proper/sanselan/trunk/src/main/java/org/apache/sanselan/formats/tiff/photometricinterpreters/PhotometricInterpreterLogLUV.java (original) +++ commons/proper/sanselan/trunk/src/main/java/org/apache/sanselan/formats/tiff/photometricinterpreters/PhotometricInterpreterLogLUV.java Fri Mar 12 18:47:22 2010 @@ -139,9 +139,9 @@ public class PhotometricInterpreterLogLU // R, G, B, // }, maxRGB, minRGB); - int red = (int) R; - int green = (int) G; - int blue = (int) B; + int red = R; + int green = G; + int blue = B; red = Math.min(255, Math.max(0, red)); green = Math.min(255, Math.max(0, green));