commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject svn commit: r928107 - in /commons/proper/codec/trunk: src/java/org/apache/commons/codec/binary/Base64.java src/java/org/apache/commons/codec/binary/Base64InputStream.java src/java/org/apache/commons/codec/binary/Base64OutputStream.java xdocs/changes.xml
Date Sat, 27 Mar 2010 00:02:22 GMT
Author: sebb
Date: Sat Mar 27 00:02:22 2010
New Revision: 928107

URL: http://svn.apache.org/viewvc?rev=928107&view=rev
Log:
JIRA: CODEC-89 new Base64().encode() appends a CRLF, and chunks results into 76 character
lines

Modified:
    commons/proper/codec/trunk/src/java/org/apache/commons/codec/binary/Base64.java
    commons/proper/codec/trunk/src/java/org/apache/commons/codec/binary/Base64InputStream.java
    commons/proper/codec/trunk/src/java/org/apache/commons/codec/binary/Base64OutputStream.java
    commons/proper/codec/trunk/xdocs/changes.xml

Modified: commons/proper/codec/trunk/src/java/org/apache/commons/codec/binary/Base64.java
URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/java/org/apache/commons/codec/binary/Base64.java?rev=928107&r1=928106&r2=928107&view=diff
==============================================================================
--- commons/proper/codec/trunk/src/java/org/apache/commons/codec/binary/Base64.java (original)
+++ commons/proper/codec/trunk/src/java/org/apache/commons/codec/binary/Base64.java Sat Mar
27 00:02:22 2010
@@ -214,7 +214,7 @@ public class Base64 implements BinaryEnc
     /**
      * Creates a Base64 codec used for decoding (all modes) and encoding in URL-unsafe mode.
      * <p>
-     * When encoding the line length is 76, the line separator is CRLF, and the encoding
table is STANDARD_ENCODE_TABLE.
+     * When encoding the line length is 0 (no chunking), and the encoding table is STANDARD_ENCODE_TABLE.
      * </p>
      * 
      * <p>
@@ -222,7 +222,7 @@ public class Base64 implements BinaryEnc
      * </p>
      */
     public Base64() {
-        this(false);
+        this(0);
     }
 
     /**

Modified: commons/proper/codec/trunk/src/java/org/apache/commons/codec/binary/Base64InputStream.java
URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/java/org/apache/commons/codec/binary/Base64InputStream.java?rev=928107&r1=928106&r2=928107&view=diff
==============================================================================
--- commons/proper/codec/trunk/src/java/org/apache/commons/codec/binary/Base64InputStream.java
(original)
+++ commons/proper/codec/trunk/src/java/org/apache/commons/codec/binary/Base64InputStream.java
Sat Mar 27 00:02:22 2010
@@ -73,7 +73,7 @@ public class Base64InputStream extends F
     public Base64InputStream(InputStream in, boolean doEncode) {
         super(in);
         this.doEncode = doEncode;
-        this.base64 = new Base64();
+        this.base64 = new Base64(false);
     }
 
     /**

Modified: commons/proper/codec/trunk/src/java/org/apache/commons/codec/binary/Base64OutputStream.java
URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/java/org/apache/commons/codec/binary/Base64OutputStream.java?rev=928107&r1=928106&r2=928107&view=diff
==============================================================================
--- commons/proper/codec/trunk/src/java/org/apache/commons/codec/binary/Base64OutputStream.java
(original)
+++ commons/proper/codec/trunk/src/java/org/apache/commons/codec/binary/Base64OutputStream.java
Sat Mar 27 00:02:22 2010
@@ -72,7 +72,7 @@ public class Base64OutputStream extends 
     public Base64OutputStream(OutputStream out, boolean doEncode) {
         super(out);
         this.doEncode = doEncode;
-        this.base64 = new Base64();
+        this.base64 = new Base64(false);
     }
 
     /**

Modified: commons/proper/codec/trunk/xdocs/changes.xml
URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/xdocs/changes.xml?rev=928107&r1=928106&r2=928107&view=diff
==============================================================================
--- commons/proper/codec/trunk/xdocs/changes.xml (original)
+++ commons/proper/codec/trunk/xdocs/changes.xml Sat Mar 27 00:02:22 2010
@@ -23,6 +23,9 @@
     </properties>
     <body>
         <release version="TBA" date="TBA" description="TBC">
+            <action dev="sebb" type="fix" issue="CODEC-89">
+             new Base64().encode() appends a CRLF, and chunks results into 76 character lines
+            </action>
             <action dev="sebb" type="add" issue="CODEC-93" due-to="Julius Davies">
              Add test(s) to check that encodeBase64() does not chunk output.
              </action>



Mime
View raw message