Return-Path: Delivered-To: apmail-commons-commits-archive@minotaur.apache.org Received: (qmail 1716 invoked from network); 3 Feb 2010 07:38:42 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 3 Feb 2010 07:38:42 -0000 Received: (qmail 42486 invoked by uid 500); 3 Feb 2010 07:38:41 -0000 Delivered-To: apmail-commons-commits-archive@commons.apache.org Received: (qmail 42433 invoked by uid 500); 3 Feb 2010 07:38:41 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 42424 invoked by uid 99); 3 Feb 2010 07:38:41 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Feb 2010 07:38:41 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Feb 2010 07:38:39 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 0BF2D23889F7; Wed, 3 Feb 2010 07:38:18 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r905922 - /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/exception/DefaultExceptionContext.java Date: Wed, 03 Feb 2010 07:38:17 -0000 To: commits@commons.apache.org From: bayard@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20100203073818.0BF2D23889F7@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: bayard Date: Wed Feb 3 07:38:17 2010 New Revision: 905922 URL: http://svn.apache.org/viewvc?rev=905922&view=rev Log: Fixing LANG-585. Don't catch Throwable, catch Exception instead. Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/exception/DefaultExceptionContext.java Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/exception/DefaultExceptionContext.java URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/exception/DefaultExceptionContext.java?rev=905922&r1=905921&r2=905922&view=diff ============================================================================== --- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/exception/DefaultExceptionContext.java (original) +++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/exception/DefaultExceptionContext.java Wed Feb 3 07:38:17 2010 @@ -104,10 +104,11 @@ buffer.append("null"); } else { - try {valueStr = value.toString();} - catch (Throwable t) { - valueStr = "Excepted on toString(): " + - ExceptionUtils.getStackTrace(t); + try { + valueStr = value.toString(); + } + catch (Exception e) { + valueStr = "Exception thrown on toString(): " + ExceptionUtils.getStackTrace(e); } buffer.append(valueStr); }