Return-Path: Delivered-To: apmail-commons-commits-archive@minotaur.apache.org Received: (qmail 15526 invoked from network); 5 Jan 2010 03:13:12 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 5 Jan 2010 03:13:12 -0000 Received: (qmail 26314 invoked by uid 500); 5 Jan 2010 03:13:11 -0000 Delivered-To: apmail-commons-commits-archive@commons.apache.org Received: (qmail 26147 invoked by uid 500); 5 Jan 2010 03:13:11 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 26136 invoked by uid 99); 5 Jan 2010 03:13:10 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Jan 2010 03:13:10 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Jan 2010 03:13:09 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id F363823889CB; Tue, 5 Jan 2010 03:12:47 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r895871 - in /commons/proper/dbcp/trunk: src/java/org/apache/commons/dbcp/PoolingDriver.java xdocs/changes.xml Date: Tue, 05 Jan 2010 03:12:40 -0000 To: commits@commons.apache.org From: sebb@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20100105031247.F363823889CB@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: sebb Date: Tue Jan 5 03:12:26 2010 New Revision: 895871 URL: http://svn.apache.org/viewvc?rev=895871&view=rev Log: DBCP-315 Remove throws clause from method that does not throw an exception. Modified: commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/PoolingDriver.java commons/proper/dbcp/trunk/xdocs/changes.xml Modified: commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/PoolingDriver.java URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/PoolingDriver.java?rev=895871&r1=895870&r2=895871&view=diff ============================================================================== --- commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/PoolingDriver.java (original) +++ commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/PoolingDriver.java Tue Jan 5 03:12:26 2010 @@ -157,7 +157,7 @@ } } - public synchronized String[] getPoolNames() throws SQLException{ + public synchronized String[] getPoolNames(){ Set names = _pools.keySet(); return (String[]) names.toArray(new String[names.size()]); } Modified: commons/proper/dbcp/trunk/xdocs/changes.xml URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/xdocs/changes.xml?rev=895871&r1=895870&r2=895871&view=diff ============================================================================== --- commons/proper/dbcp/trunk/xdocs/changes.xml (original) +++ commons/proper/dbcp/trunk/xdocs/changes.xml Tue Jan 5 03:12:26 2010 @@ -49,6 +49,9 @@ changes below since 1.2.2 applies to both the 1.3 and 1.4 release. Other than the one issue related to adding JDBC 4 support (DBCP-191), all bug fixes or new features are included in both DBCP 1.3 and 1.4 "> + + Remove throws clause from method that does not throw an exception. + Remove code that catches and ignores Exceptions when calling PooledConnection.removeConnectionEventListener(ConnectionEventListener)