commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject svn commit: r903854 - in /commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp: ./ parser/
Date Wed, 27 Jan 2010 22:04:13 GMT
Author: sebb
Date: Wed Jan 27 22:04:13 2010
New Revision: 903854

URL: http://svn.apache.org/viewvc?rev=903854&view=rev
Log:
Make private fields final

Modified:
    commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp/FTPClient.java
    commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp/FTPClientConfig.java
    commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp/FTPListParseEngine.java
    commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp/FTPSServerSocketFactory.java
    commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp/parser/ConfigurableFTPFileEntryParserImpl.java
    commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp/parser/VMSVersioningFTPEntryParser.java

Modified: commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp/FTPClient.java
URL: http://svn.apache.org/viewvc/commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp/FTPClient.java?rev=903854&r1=903853&r2=903854&view=diff
==============================================================================
--- commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp/FTPClient.java
(original)
+++ commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp/FTPClient.java
Wed Jan 27 22:04:13 2010
@@ -286,8 +286,8 @@
     private FTPClientConfig __configuration;
 
     /** Pattern for PASV mode responses */ 
-    private static String __parms = "\\d{1,3},\\d{1,3},\\d{1,3},\\d{1,3},\\d{1,3},\\d{1,3}";
-    private static java.util.regex.Pattern __parms_pat;
+    private static final String __parms = "\\d{1,3},\\d{1,3},\\d{1,3},\\d{1,3},\\d{1,3},\\d{1,3}";
+    private static final java.util.regex.Pattern __parms_pat;
     static {
        __parms_pat = java.util.regex.Pattern.compile(__parms);
     }

Modified: commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp/FTPClientConfig.java
URL: http://svn.apache.org/viewvc/commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp/FTPClientConfig.java?rev=903854&r1=903853&r2=903854&view=diff
==============================================================================
--- commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp/FTPClientConfig.java
(original)
+++ commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp/FTPClientConfig.java
Wed Jan 27 22:04:13 2010
@@ -262,7 +262,7 @@
         this.serverTimeZoneId = serverTimeZoneId;
     }
     
-    private static Map<String, Object> LANGUAGE_CODE_MAP = new TreeMap<String, Object>();
+    private static final Map<String, Object> LANGUAGE_CODE_MAP = new TreeMap<String,
Object>();
     static {
         
         // if there are other commonly used month name encodings which

Modified: commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp/FTPListParseEngine.java
URL: http://svn.apache.org/viewvc/commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp/FTPListParseEngine.java?rev=903854&r1=903853&r2=903854&view=diff
==============================================================================
--- commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp/FTPListParseEngine.java
(original)
+++ commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp/FTPListParseEngine.java
Wed Jan 27 22:04:13 2010
@@ -76,7 +76,7 @@
     private List<String> entries = new LinkedList<String>();
     private ListIterator<String> _internalIterator = entries.listIterator();
 
-    FTPFileEntryParser parser = null;
+    private final FTPFileEntryParser parser;
 
     public FTPListParseEngine(FTPFileEntryParser parser) {
         this.parser = parser;

Modified: commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp/FTPSServerSocketFactory.java
URL: http://svn.apache.org/viewvc/commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp/FTPSServerSocketFactory.java?rev=903854&r1=903853&r2=903854&view=diff
==============================================================================
--- commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp/FTPSServerSocketFactory.java
(original)
+++ commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp/FTPSServerSocketFactory.java
Wed Jan 27 22:04:13 2010
@@ -31,7 +31,7 @@
 public class FTPSServerSocketFactory extends ServerSocketFactory {
     
 	/** Factory for secure socket factories */
-    private SSLContext context;
+    private final SSLContext context;
     
     public FTPSServerSocketFactory(SSLContext context) {
         this.context = context;

Modified: commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp/parser/ConfigurableFTPFileEntryParserImpl.java
URL: http://svn.apache.org/viewvc/commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp/parser/ConfigurableFTPFileEntryParserImpl.java?rev=903854&r1=903853&r2=903854&view=diff
==============================================================================
--- commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp/parser/ConfigurableFTPFileEntryParserImpl.java
(original)
+++ commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp/parser/ConfigurableFTPFileEntryParserImpl.java
Wed Jan 27 22:04:13 2010
@@ -47,10 +47,10 @@
 implements Configurable 
 {
 
-    private FTPTimestampParser timestampParser;
+    private final FTPTimestampParser timestampParser;
     
     /**
-     * Only constructor for this absract class.
+     * Only constructor for this abstract class.
      * @param regex  Regular expression used main parsing of the 
      * file listing.
      */

Modified: commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp/parser/VMSVersioningFTPEntryParser.java
URL: http://svn.apache.org/viewvc/commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp/parser/VMSVersioningFTPEntryParser.java?rev=903854&r1=903853&r2=903854&view=diff
==============================================================================
--- commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp/parser/VMSVersioningFTPEntryParser.java
(original)
+++ commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp/parser/VMSVersioningFTPEntryParser.java
Wed Jan 27 22:04:13 2010
@@ -99,8 +99,8 @@
 
 
     private static class NameVersion {
-        String name;
-        int versionNumber;
+        final String name;
+        final int versionNumber;
         NameVersion(String name, String vers) {
             this.name = name;
             this.versionNumber = Integer.parseInt(vers);



Mime
View raw message