commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ohe...@apache.org
Subject svn commit: r895222 - /commons/proper/configuration/trunk/src/test/org/apache/commons/configuration/TestXMLConfiguration.java
Date Sat, 02 Jan 2010 16:25:23 GMT
Author: oheger
Date: Sat Jan  2 16:25:22 2010
New Revision: 895222

URL: http://svn.apache.org/viewvc?rev=895222&view=rev
Log:
Make tests a bit faster by reducing the loop count in tests with multiple threads.

Modified:
    commons/proper/configuration/trunk/src/test/org/apache/commons/configuration/TestXMLConfiguration.java

Modified: commons/proper/configuration/trunk/src/test/org/apache/commons/configuration/TestXMLConfiguration.java
URL: http://svn.apache.org/viewvc/commons/proper/configuration/trunk/src/test/org/apache/commons/configuration/TestXMLConfiguration.java?rev=895222&r1=895221&r2=895222&view=diff
==============================================================================
--- commons/proper/configuration/trunk/src/test/org/apache/commons/configuration/TestXMLConfiguration.java
(original)
+++ commons/proper/configuration/trunk/src/test/org/apache/commons/configuration/TestXMLConfiguration.java
Sat Jan  2 16:25:22 2010
@@ -38,9 +38,9 @@
 
 import org.apache.commons.configuration.reloading.FileAlwaysReloadingStrategy;
 import org.apache.commons.configuration.reloading.InvariantReloadingStrategy;
+import org.apache.commons.configuration.resolver.CatalogResolver;
 import org.apache.commons.configuration.tree.ConfigurationNode;
 import org.apache.commons.configuration.tree.xpath.XPathExpressionEngine;
-import org.apache.commons.configuration.resolver.CatalogResolver;
 import org.xml.sax.SAXException;
 import org.xml.sax.SAXParseException;
 import org.xml.sax.helpers.DefaultHandler;
@@ -79,6 +79,12 @@
     private File testSaveFile = new File("target/testsample2.xml");
     private String testFile2 = new File("conf/sample.xml").getAbsolutePath();
 
+    /** Constant for the number of test threads. */
+    private static final int THREAD_COUNT = 5;
+
+    /** Constant for the number of loops in tests with multiple threads. */
+    private static final int LOOP_COUNT = 100;
+
     private XMLConfiguration conf;
 
     protected void setUp() throws Exception
@@ -658,7 +664,7 @@
             conf.load();
             assertEquals(1, conf.getInt("test"));
 
-            for (int i = 1; i < 50000; ++i)
+            for (int i = 1; i < LOOP_COUNT; ++i)
             {
                assertEquals(1, conf.getInt("test"));
             }
@@ -1638,7 +1644,7 @@
 
         assertTrue("Property not found", config.getProperty("test.short") != null);
 
-        Thread testThreads[] = new Thread[5];
+        Thread testThreads[] = new Thread[THREAD_COUNT];
 
         for (int i = 0; i < testThreads.length; ++i)
         {
@@ -1646,7 +1652,7 @@
             testThreads[i].start();
         }
 
-        for (int i = 0; i < 2000; i++)
+        for (int i = 0; i < LOOP_COUNT; i++)
         {
             assertTrue("Property not found", config.getProperty("test.short") != null);
         }
@@ -1667,7 +1673,7 @@
         }
         public void run()
         {
-            for (int i = 0; i < 1000; i++)
+            for (int i = 0; i < LOOP_COUNT; i++)
             {
                 config.reload();
             }



Mime
View raw message