commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject svn commit: r886286 - /commons/proper/codec/trunk/src/test/org/apache/commons/codec/binary/StringUtilsTest.java
Date Wed, 02 Dec 2009 19:39:11 GMT
Author: sebb
Date: Wed Dec  2 19:39:11 2009
New Revision: 886286

URL: http://svn.apache.org/viewvc?rev=886286&view=rev
Log:
No point in using getBytes() on "abc" - just code the bytes directly.

Modified:
    commons/proper/codec/trunk/src/test/org/apache/commons/codec/binary/StringUtilsTest.java

Modified: commons/proper/codec/trunk/src/test/org/apache/commons/codec/binary/StringUtilsTest.java
URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/test/org/apache/commons/codec/binary/StringUtilsTest.java?rev=886286&r1=886285&r2=886286&view=diff
==============================================================================
--- commons/proper/codec/trunk/src/test/org/apache/commons/codec/binary/StringUtilsTest.java
(original)
+++ commons/proper/codec/trunk/src/test/org/apache/commons/codec/binary/StringUtilsTest.java
Wed Dec  2 19:39:11 2009
@@ -31,18 +31,10 @@
  */
 public class StringUtilsTest extends TestCase {
 
-    private static byte[] BYTES_FIXTURE;
+    private static final byte[] BYTES_FIXTURE = {'a','b','c'};
 
     private static final String STRING_FIXTURE = "ABC";
 
-    {
-        try {
-            BYTES_FIXTURE = "abc".getBytes("US-ASCII");
-        } catch (UnsupportedEncodingException e) {
-            throw new IllegalArgumentException(e.toString());
-        }
-    }
-
     /**
      * We could make the constructor private but there does not seem to be a point to jumping
through extra code hoops
      * to restrict instantiation right now.



Mime
View raw message