Return-Path: Delivered-To: apmail-commons-commits-archive@minotaur.apache.org Received: (qmail 6246 invoked from network); 23 Nov 2009 15:50:10 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 23 Nov 2009 15:50:10 -0000 Received: (qmail 4824 invoked by uid 500); 23 Nov 2009 15:50:10 -0000 Delivered-To: apmail-commons-commits-archive@commons.apache.org Received: (qmail 4744 invoked by uid 500); 23 Nov 2009 15:50:09 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 4735 invoked by uid 99); 23 Nov 2009 15:50:09 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Nov 2009 15:50:09 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Nov 2009 15:50:07 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 7CFEF238899C; Mon, 23 Nov 2009 15:49:46 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r883381 - in /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp: TestManual.java datasources/TestPerUserPoolDataSource.java datasources/TestSharedPoolDataSource.java Date: Mon, 23 Nov 2009 15:49:46 -0000 To: commits@commons.apache.org From: markt@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20091123154946.7CFEF238899C@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: markt Date: Mon Nov 23 15:49:45 2009 New Revision: 883381 URL: http://svn.apache.org/viewvc?rev=883381&view=rev Log: Fix FindBugs warnings Call super.setUp() / super.tearDown() Modified: commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestManual.java commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/datasources/TestPerUserPoolDataSource.java commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/datasources/TestSharedPoolDataSource.java Modified: commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestManual.java URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestManual.java?rev=883381&r1=883380&r2=883381&view=diff ============================================================================== --- commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestManual.java (original) +++ commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestManual.java Mon Nov 23 15:49:45 2009 @@ -69,6 +69,7 @@ public void tearDown() throws Exception { driver.closePool("test"); DriverManager.deregisterDriver(driver); + super.tearDown(); } public void test1() { Modified: commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/datasources/TestPerUserPoolDataSource.java URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/datasources/TestPerUserPoolDataSource.java?rev=883381&r1=883380&r2=883381&view=diff ============================================================================== --- commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/datasources/TestPerUserPoolDataSource.java (original) +++ commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/datasources/TestPerUserPoolDataSource.java Mon Nov 23 15:49:45 2009 @@ -56,6 +56,7 @@ private DataSource ds; public void setUp() throws Exception { + super.setUp(); DriverAdapterCPDS pcds = new DriverAdapterCPDS(); pcds.setDriver("org.apache.commons.dbcp.TesterDriver"); pcds.setUrl("jdbc:apache:commons:testdriver"); Modified: commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/datasources/TestSharedPoolDataSource.java URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/datasources/TestSharedPoolDataSource.java?rev=883381&r1=883380&r2=883381&view=diff ============================================================================== --- commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/datasources/TestSharedPoolDataSource.java (original) +++ commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/datasources/TestSharedPoolDataSource.java Mon Nov 23 15:49:45 2009 @@ -53,6 +53,7 @@ private DataSource ds; public void setUp() throws Exception { + super.setUp(); pcds = new DriverAdapterCPDS(); pcds.setDriver("org.apache.commons.dbcp.TesterDriver"); pcds.setUrl("jdbc:apache:commons:testdriver");