Return-Path: Delivered-To: apmail-commons-commits-archive@minotaur.apache.org Received: (qmail 39219 invoked from network); 1 Nov 2009 15:29:28 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 1 Nov 2009 15:29:28 -0000 Received: (qmail 83350 invoked by uid 500); 1 Nov 2009 15:29:27 -0000 Delivered-To: apmail-commons-commits-archive@commons.apache.org Received: (qmail 83255 invoked by uid 500); 1 Nov 2009 15:29:27 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 83246 invoked by uid 99); 1 Nov 2009 15:29:27 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 01 Nov 2009 15:29:27 +0000 X-ASF-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 01 Nov 2009 15:29:25 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id C4D85238890E; Sun, 1 Nov 2009 15:29:04 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r831687 - in /commons/proper/lang/trunk/src: java/org/apache/commons/lang/EnumUtils.java test/org/apache/commons/lang/EnumUtilsTest.java Date: Sun, 01 Nov 2009 15:29:04 -0000 To: commits@commons.apache.org From: scolebourne@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20091101152904.C4D85238890E@eris.apache.org> Author: scolebourne Date: Sun Nov 1 15:29:04 2009 New Revision: 831687 URL: http://svn.apache.org/viewvc?rev=831687&view=rev Log: LANG-290 - Rename isEnum to isValidEnum Modified: commons/proper/lang/trunk/src/java/org/apache/commons/lang/EnumUtils.java commons/proper/lang/trunk/src/test/org/apache/commons/lang/EnumUtilsTest.java Modified: commons/proper/lang/trunk/src/java/org/apache/commons/lang/EnumUtils.java URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/java/org/apache/commons/lang/EnumUtils.java?rev=831687&r1=831686&r2=831687&view=diff ============================================================================== --- commons/proper/lang/trunk/src/java/org/apache/commons/lang/EnumUtils.java (original) +++ commons/proper/lang/trunk/src/java/org/apache/commons/lang/EnumUtils.java Sun Nov 1 15:29:04 2009 @@ -73,7 +73,7 @@ * @param enumClass the class of the enum to get, not null * @return the map of enum names to enums, never null */ - public static > boolean isEnum(Class enumClass, String enumName) { + public static > boolean isValidEnum(Class enumClass, String enumName) { try { Enum.valueOf(enumClass, enumName); return true; Modified: commons/proper/lang/trunk/src/test/org/apache/commons/lang/EnumUtilsTest.java URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/org/apache/commons/lang/EnumUtilsTest.java?rev=831687&r1=831686&r2=831687&view=diff ============================================================================== --- commons/proper/lang/trunk/src/test/org/apache/commons/lang/EnumUtilsTest.java (original) +++ commons/proper/lang/trunk/src/test/org/apache/commons/lang/EnumUtilsTest.java Sun Nov 1 15:29:04 2009 @@ -60,10 +60,10 @@ } public void test_isEnum() { - assertEquals(true, EnumUtils.isEnum(Traffic.class, "RED")); - assertEquals(true, EnumUtils.isEnum(Traffic.class, "AMBER")); - assertEquals(true, EnumUtils.isEnum(Traffic.class, "GREEN")); - assertEquals(false, EnumUtils.isEnum(Traffic.class, "PURPLE")); + assertEquals(true, EnumUtils.isValidEnum(Traffic.class, "RED")); + assertEquals(true, EnumUtils.isValidEnum(Traffic.class, "AMBER")); + assertEquals(true, EnumUtils.isValidEnum(Traffic.class, "GREEN")); + assertEquals(false, EnumUtils.isValidEnum(Traffic.class, "PURPLE")); } public void test_getEnum() {