commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nia...@apache.org
Subject svn commit: r885178 - /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/managed/BasicManagedDataSource.java
Date Sun, 29 Nov 2009 00:08:59 GMT
Author: niallp
Date: Sun Nov 29 00:08:59 2009
New Revision: 885178

URL: http://svn.apache.org/viewvc?rev=885178&view=rev
Log:
DBCP-311 Don't log and re-throw exceptions

Modified:
    commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/managed/BasicManagedDataSource.java

Modified: commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/managed/BasicManagedDataSource.java
URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/managed/BasicManagedDataSource.java?rev=885178&r1=885177&r2=885178&view=diff
==============================================================================
--- commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/managed/BasicManagedDataSource.java
(original)
+++ commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/managed/BasicManagedDataSource.java
Sun Nov 29 00:08:59 2009
@@ -145,8 +145,6 @@
                 xaDataSourceClass = Class.forName(xaDataSource);
             } catch (Throwable t) {
                 String message = "Cannot load XA data source class '" + xaDataSource + "'";
-                logWriter.println(message);
-                t.printStackTrace(logWriter);
                 throw (SQLException)new SQLException(message).initCause(t);
             }
             
@@ -154,8 +152,6 @@
                 xaDataSourceInstance = (XADataSource) xaDataSourceClass.newInstance();
             } catch (Throwable t) {
                 String message = "Cannot create XA data source of class '" + xaDataSource
+ "'";
-                logWriter.println(message);
-                t.printStackTrace(logWriter);
                 throw (SQLException)new SQLException(message).initCause(t);
             }
         }



Mime
View raw message