commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject svn commit: r883463 - /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/datasources/TestSharedPoolDataSource.java
Date Mon, 23 Nov 2009 19:01:39 GMT
Author: sebb
Date: Mon Nov 23 19:01:38 2009
New Revision: 883463

URL: http://svn.apache.org/viewvc?rev=883463&view=rev
Log:
Tidy variables

Modified:
    commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/datasources/TestSharedPoolDataSource.java

Modified: commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/datasources/TestSharedPoolDataSource.java
URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/datasources/TestSharedPoolDataSource.java?rev=883463&r1=883462&r2=883463&view=diff
==============================================================================
--- commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/datasources/TestSharedPoolDataSource.java
(original)
+++ commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/datasources/TestSharedPoolDataSource.java
Mon Nov 23 19:01:38 2009
@@ -415,13 +415,13 @@
         /**
          * The number of milliseconds to hold onto a database connection
          */
-        private int connHoldTime;
+        private final int connHoldTime;
 
-        private boolean isRun;
+        private volatile boolean isRun; // shared across threads
 
-        private String state;
+        private volatile String state; // sharead across threads
 
-        boolean isStopOnException;
+        private final boolean isStopOnException;
 
         protected PoolTest(ThreadGroup threadGroup, int connHoldTime) {
             this(threadGroup, connHoldTime, false);



Mime
View raw message