commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject svn commit: r883366 - /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/PoolingConnection.java
Date Mon, 23 Nov 2009 15:16:43 GMT
Author: sebb
Date: Mon Nov 23 15:16:36 2009
New Revision: 883366

URL: http://svn.apache.org/viewvc?rev=883366&view=rev
Log:
Don't catch Exception when only SQLException is thrown
(this agrees with other createKey() methods)

Modified:
    commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/PoolingConnection.java

Modified: commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/PoolingConnection.java
URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/PoolingConnection.java?rev=883366&r1=883365&r2=883366&view=diff
==============================================================================
--- commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/PoolingConnection.java (original)
+++ commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/PoolingConnection.java Mon
Nov 23 15:16:36 2009
@@ -226,7 +226,7 @@
         String catalog = null;
         try {
             catalog = getCatalog();
-        } catch (Exception e) {}
+        } catch (SQLException e) {}
         return new PStmtKey(normalizeSQL(sql), catalog, resultSetType, resultSetConcurrency,
stmtType);
     }
 
@@ -248,7 +248,7 @@
         String catalog = null;
         try {
             catalog = getCatalog();
-        } catch (Exception e) {}
+        } catch (SQLException e) {}
         return new PStmtKey(normalizeSQL(sql), catalog, stmtType);
     }
 



Mime
View raw message