Return-Path: Delivered-To: apmail-commons-commits-archive@minotaur.apache.org Received: (qmail 39462 invoked from network); 23 Oct 2009 06:45:09 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 23 Oct 2009 06:45:09 -0000 Received: (qmail 67794 invoked by uid 500); 23 Oct 2009 06:45:08 -0000 Delivered-To: apmail-commons-commits-archive@commons.apache.org Received: (qmail 67719 invoked by uid 500); 23 Oct 2009 06:45:08 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 67710 invoked by uid 99); 23 Oct 2009 06:45:08 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Oct 2009 06:45:08 +0000 X-ASF-Spam-Status: No, hits=-3.8 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Oct 2009 06:45:06 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 6927F2388909; Fri, 23 Oct 2009 06:44:46 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r828943 - /commons/proper/lang/trunk/src/java/org/apache/commons/lang/text/translate/LookupTranslator.java Date: Fri, 23 Oct 2009 06:44:46 -0000 To: commits@commons.apache.org From: bayard@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20091023064446.6927F2388909@eris.apache.org> Author: bayard Date: Fri Oct 23 06:44:45 2009 New Revision: 828943 URL: http://svn.apache.org/viewvc?rev=828943&view=rev Log: Making private fields final per Sebb's patch to LANG-540 Modified: commons/proper/lang/trunk/src/java/org/apache/commons/lang/text/translate/LookupTranslator.java Modified: commons/proper/lang/trunk/src/java/org/apache/commons/lang/text/translate/LookupTranslator.java URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/java/org/apache/commons/lang/text/translate/LookupTranslator.java?rev=828943&r1=828942&r2=828943&view=diff ============================================================================== --- commons/proper/lang/trunk/src/java/org/apache/commons/lang/text/translate/LookupTranslator.java (original) +++ commons/proper/lang/trunk/src/java/org/apache/commons/lang/text/translate/LookupTranslator.java Fri Oct 23 06:44:45 2009 @@ -27,9 +27,9 @@ // TODO: Replace with a RegexLookup? Performance test. public class LookupTranslator extends CharSequenceTranslator { - private HashMap lookupMap; - private int shortest = Integer.MAX_VALUE; - private int longest = 0; + private final HashMap lookupMap; + private final int shortest; + private final int longest; /** * Define the lookup table to be used in translation @@ -38,16 +38,20 @@ */ public LookupTranslator(CharSequence[][] lookup) { lookupMap = new HashMap(); + int _shortest = Integer.MAX_VALUE; + int _longest = 0; for(CharSequence[] seq : lookup) { this.lookupMap.put(seq[0], seq[1]); int sz = seq[0].length(); - if(sz < shortest) { - shortest = sz; + if(sz < _shortest) { + _shortest = sz; } - if(sz > longest) { - longest = sz; + if(sz > _longest) { + _longest = sz; } } + shortest = _shortest; + longest = _longest; } /**