Return-Path: Delivered-To: apmail-commons-commits-archive@minotaur.apache.org Received: (qmail 18097 invoked from network); 15 Sep 2009 05:55:17 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 15 Sep 2009 05:55:17 -0000 Received: (qmail 98991 invoked by uid 500); 15 Sep 2009 05:55:16 -0000 Delivered-To: apmail-commons-commits-archive@commons.apache.org Received: (qmail 98904 invoked by uid 500); 15 Sep 2009 05:55:16 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 98685 invoked by uid 99); 15 Sep 2009 05:55:15 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Sep 2009 05:55:15 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Sep 2009 05:55:11 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id D15D923889C8; Tue, 15 Sep 2009 05:54:04 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r815016 - /commons/proper/collections/trunk/src/java/org/apache/commons/collections/bag/SynchronizedSortedBag.java Date: Tue, 15 Sep 2009 05:54:04 -0000 To: commits@commons.apache.org From: bayard@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20090915055404.D15D923889C8@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: bayard Date: Tue Sep 15 05:54:04 2009 New Revision: 815016 URL: http://svn.apache.org/viewvc?rev=815016&view=rev Log: Merging from -r468106:814127 of collections_jdk5_branch - namely where this code was generified; mostly in r738956. Also see the following revisions: ------------------------------------------------------------------------ r555925 | skestle | 2007-07-13 03:39:24 -0700 (Fri, 13 Jul 2007) | 2 lines Added Edwin Tellman's patch for COLLECTIONS-243. It all seems pretty reasonable, and it should all be checked again as the project is worked through ------------------------------------------------------------------------ Modified: commons/proper/collections/trunk/src/java/org/apache/commons/collections/bag/SynchronizedSortedBag.java Modified: commons/proper/collections/trunk/src/java/org/apache/commons/collections/bag/SynchronizedSortedBag.java URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/java/org/apache/commons/collections/bag/SynchronizedSortedBag.java?rev=815016&r1=815015&r2=815016&view=diff ============================================================================== --- commons/proper/collections/trunk/src/java/org/apache/commons/collections/bag/SynchronizedSortedBag.java (original) +++ commons/proper/collections/trunk/src/java/org/apache/commons/collections/bag/SynchronizedSortedBag.java Tue Sep 15 05:54:04 2009 @@ -35,8 +35,8 @@ * * @author Stephen Colebourne */ -public class SynchronizedSortedBag - extends SynchronizedBag implements SortedBag { +public class SynchronizedSortedBag + extends SynchronizedBag implements SortedBag { /** Serialization version */ private static final long serialVersionUID = 722374056718497858L; @@ -48,8 +48,8 @@ * @return a new synchronized SortedBag * @throws IllegalArgumentException if bag is null */ - public static SortedBag decorate(SortedBag bag) { - return new SynchronizedSortedBag(bag); + public static SortedBag decorate(SortedBag bag) { + return new SynchronizedSortedBag(bag); } //----------------------------------------------------------------------- @@ -59,7 +59,7 @@ * @param bag the bag to decorate, must not be null * @throws IllegalArgumentException if bag is null */ - protected SynchronizedSortedBag(SortedBag bag) { + protected SynchronizedSortedBag(SortedBag bag) { super(bag); } @@ -70,7 +70,7 @@ * @param lock the lock to use, must not be null * @throws IllegalArgumentException if bag is null */ - protected SynchronizedSortedBag(Bag bag, Object lock) { + protected SynchronizedSortedBag(Bag bag, Object lock) { super(bag, lock); } @@ -79,24 +79,24 @@ * * @return the decorated bag */ - protected SortedBag getSortedBag() { - return (SortedBag) collection; + protected SortedBag getSortedBag() { + return (SortedBag) collection; } //----------------------------------------------------------------------- - public synchronized Object first() { + public synchronized E first() { synchronized (lock) { return getSortedBag().first(); } } - public synchronized Object last() { + public synchronized E last() { synchronized (lock) { return getSortedBag().last(); } } - public synchronized Comparator comparator() { + public synchronized Comparator comparator() { synchronized (lock) { return getSortedBag().comparator(); }