Return-Path: 
 <commits-return-7873-apmail-commons-commits-archive=commons.apache.org@commons.apache.org>
Delivered-To: apmail-commons-commits-archive@minotaur.apache.org
Received: (qmail 72926 invoked from network); 9 Aug 2009 10:07:21 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3)
  by minotaur.apache.org with SMTP; 9 Aug 2009 10:07:21 -0000
Received: (qmail 24996 invoked by uid 500); 9 Aug 2009 10:07:28 -0000
Delivered-To: apmail-commons-commits-archive@commons.apache.org
Received: (qmail 24884 invoked by uid 500); 9 Aug 2009 10:07:28 -0000
Mailing-List: contact commits-help@commons.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@commons.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@commons.apache.org>
List-Post: <mailto:commits@commons.apache.org>
List-Id: <commits.commons.apache.org>
Reply-To: dev@commons.apache.org
Delivered-To: mailing list commits@commons.apache.org
Received: (qmail 24875 invoked by uid 99); 9 Aug 2009 10:07:28 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 09 Aug 2009 10:07:28 +0000
X-ASF-Spam-Status: No, hits=-2000.0 required=10.0
	tests=ALL_TRUSTED
X-Spam-Check-By: apache.org
Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 09 Aug 2009 10:07:26 +0000
Received: by eris.apache.org (Postfix, from userid 65534)
	id 36AF923888D7; Sun,  9 Aug 2009 10:07:06 +0000 (UTC)
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: svn commit: r802509 - /commons/sandbox/nabla/trunk/checkstyle.xml
Date: Sun, 09 Aug 2009 10:07:06 -0000
To: commits@commons.apache.org
From: luc@apache.org
X-Mailer: svnmailer-1.0.8
Message-Id: <20090809100706.36AF923888D7@eris.apache.org>
X-Virus-Checked: Checked by ClamAV on apache.org

Author: luc
Date: Sun Aug  9 10:07:05 2009
New Revision: 802509

URL: http://svn.apache.org/viewvc?rev=802509&view=rev
Log:
prevent checkstyle from complaining about missing hidden constructor in LazyHolder classes
these classes are private internal classes and completely under control, there is no
risk anyone instantiate them and in fact it would not harm either.
Adding an hidden constructor to make checkstyle happy would make cobertura unhappy and displaying
very low coverage since cobertura currently (August 2009) cannot mark untestable methods, so it
seems better to use checkstyle filtering feature in these specific and controlled cases

Modified:
    commons/sandbox/nabla/trunk/checkstyle.xml

Modified: commons/sandbox/nabla/trunk/checkstyle.xml
URL: http://svn.apache.org/viewvc/commons/sandbox/nabla/trunk/checkstyle.xml?rev=802509&r1=802508&r2=802509&view=diff
==============================================================================
--- commons/sandbox/nabla/trunk/checkstyle.xml (original)
+++ commons/sandbox/nabla/trunk/checkstyle.xml Sun Aug  9 10:07:05 2009
@@ -83,6 +83,19 @@
                              PLUS_ASSIGN, QUESTION, RCURLY, SL, SLIST, SL_ASSIGN, SR,
                              SR_ASSIGN, STAR, STAR_ASSIGN"/>
         </module>
-    </module>
-    <module name="NewlineAtEndOfFile"/>
+
+        <!-- Required for SuppressionCommentFilter below -->
+        <module name="FileContentsHolder"/>
+
+      </module>
+  
+      <!-- Setup special comments to suppress specific checks from source files -->
+      <module name="SuppressionCommentFilter">
+          <property name="offCommentFormat" value="CHECKSTYLE\: stop HideUtilityClassConstructor"/>
+          <property name="onCommentFormat"  value="CHECKSTYLE\: resume HideUtilityClassConstructor"/>
+          <property name="checkFormat"      value="HideUtilityClassConstructor"/>
+      </module>
+
+      <module name="NewlineAtEndOfFile"/>
+
 </module>