Return-Path: Delivered-To: apmail-commons-commits-archive@minotaur.apache.org Received: (qmail 43074 invoked from network); 24 Jul 2009 22:15:47 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 24 Jul 2009 22:15:47 -0000 Received: (qmail 37146 invoked by uid 500); 24 Jul 2009 22:16:51 -0000 Delivered-To: apmail-commons-commits-archive@commons.apache.org Received: (qmail 37055 invoked by uid 500); 24 Jul 2009 22:16:51 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 37046 invoked by uid 99); 24 Jul 2009 22:16:51 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Jul 2009 22:16:51 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Jul 2009 22:16:49 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 78CC723888E4; Fri, 24 Jul 2009 22:16:29 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r797671 - /commons/proper/codec/trunk/src/test/org/apache/commons/codec/net/URLCodecTest.java Date: Fri, 24 Jul 2009 22:16:29 -0000 To: commits@commons.apache.org From: ggregory@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20090724221629.78CC723888E4@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: ggregory Date: Fri Jul 24 22:16:29 2009 New Revision: 797671 URL: http://svn.apache.org/viewvc?rev=797671&view=rev Log: Refactor comoon code. URLCodec test coverage now 100%/100%. Modified: commons/proper/codec/trunk/src/test/org/apache/commons/codec/net/URLCodecTest.java Modified: commons/proper/codec/trunk/src/test/org/apache/commons/codec/net/URLCodecTest.java URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/test/org/apache/commons/codec/net/URLCodecTest.java?rev=797671&r1=797670&r2=797671&view=diff ============================================================================== --- commons/proper/codec/trunk/src/test/org/apache/commons/codec/net/URLCodecTest.java (original) +++ commons/proper/codec/trunk/src/test/org/apache/commons/codec/net/URLCodecTest.java Fri Jul 24 22:16:29 2009 @@ -138,13 +138,21 @@ fail("DecoderException should have been thrown"); } catch (DecoderException e) { // Expected. Move on - } + } try { + // Bad 1st char after % urlCodec.decode("%WW"); fail("DecoderException should have been thrown"); } catch (DecoderException e) { // Expected. Move on } + try { + // Bad 2nd char after % + urlCodec.decode("%0W"); + fail("DecoderException should have been thrown"); + } catch (DecoderException e) { + // Expected. Move on + } this.validateState(urlCodec); }