commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pste...@apache.org
Subject svn commit: r791860 - in /commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl: TestGenericKeyedObjectPool.java TestGenericObjectPool.java
Date Tue, 07 Jul 2009 15:10:30 GMT
Author: psteitz
Date: Tue Jul  7 15:10:30 2009
New Revision: 791860

URL: http://svn.apache.org/viewvc?rev=791860&view=rev
Log:
Removed a source of spurious test failures.  Clear does not ensure numIdle == 0 as borrowed
instances can be returned during execution or before pool monitor is reacquired by the test.

Modified:
    commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestGenericKeyedObjectPool.java
    commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestGenericObjectPool.java

Modified: commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestGenericKeyedObjectPool.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestGenericKeyedObjectPool.java?rev=791860&r1=791859&r2=791860&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestGenericKeyedObjectPool.java
(original)
+++ commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestGenericKeyedObjectPool.java
Tue Jul  7 15:10:30 2009
@@ -93,7 +93,6 @@
     public void tearDown() throws Exception {
         super.tearDown();
         pool.clear();
-        assertEquals("NumIdle should be zero after clearing the pool",0,pool.getNumIdle());
         pool.close();
         pool = null;
     }

Modified: commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestGenericObjectPool.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestGenericObjectPool.java?rev=791860&r1=791859&r2=791860&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestGenericObjectPool.java
(original)
+++ commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestGenericObjectPool.java
Tue Jul  7 15:10:30 2009
@@ -68,7 +68,6 @@
     public void tearDown() throws Exception {
         super.tearDown();
         pool.clear();
-        assertEquals("NumIdle should be zero after clearing the pool",0,pool.getNumIdle());
         pool.close();
         pool = null;
     }



Mime
View raw message