commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From grobme...@apache.org
Subject svn commit: r767810 - /commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/cpio/CpioArchiveOutputStream.java
Date Thu, 23 Apr 2009 05:53:16 GMT
Author: grobmeier
Date: Thu Apr 23 05:53:16 2009
New Revision: 767810

URL: http://svn.apache.org/viewvc?rev=767810&view=rev
Log:
COMPRESS-63: fields are stored in ASCII
added javadoc

Modified:
    commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/cpio/CpioArchiveOutputStream.java

Modified: commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/cpio/CpioArchiveOutputStream.java
URL: http://svn.apache.org/viewvc/commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/cpio/CpioArchiveOutputStream.java?rev=767810&r1=767809&r2=767810&view=diff
==============================================================================
--- commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/cpio/CpioArchiveOutputStream.java
(original)
+++ commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/cpio/CpioArchiveOutputStream.java
Thu Apr 23 05:53:16 2009
@@ -372,14 +372,24 @@
         } else {
             tmpStr = tmp.substring(tmp.length() - length);
         }
-        out.write(tmpStr.getBytes()); // TODO is it correct to use the default charset here?
+        out.write(ArchiveUtils.toAsciiBytes(tmpStr));
     }
 
+    /**
+     * Writes an ASCII string to the stream followed by \0
+     * @param str the String to write
+     * @throws IOException if the string couldn't be written
+     */
     private void writeCString(final String str) throws IOException {
-        out.write(str.getBytes()); // TODO is it correct to use the default charset here?
+        out.write(ArchiveUtils.toAsciiBytes(str)); 
         out.write('\0');
     }
 
+    /**
+     * Creates a new ArchiveEntry. The entryName must be an ASCII encoded string.
+     * 
+     * @see org.apache.commons.compress.archivers.ArchiveOutputStream#createArchiveEntry(java.io.File,
java.lang.String)
+     */
     public ArchiveEntry createArchiveEntry(File inputFile, String entryName)
             throws IOException {
         return new CpioArchiveEntry(inputFile, entryName);



Mime
View raw message