Return-Path: Delivered-To: apmail-commons-commits-archive@minotaur.apache.org Received: (qmail 1560 invoked from network); 27 Mar 2009 20:45:24 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 27 Mar 2009 20:45:24 -0000 Received: (qmail 91763 invoked by uid 500); 27 Mar 2009 20:45:23 -0000 Delivered-To: apmail-commons-commits-archive@commons.apache.org Received: (qmail 91659 invoked by uid 500); 27 Mar 2009 20:45:23 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 91650 invoked by uid 99); 27 Mar 2009 20:45:23 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Mar 2009 20:45:23 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Mar 2009 20:45:21 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 5B67123888AF; Fri, 27 Mar 2009 20:45:00 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r759338 - in /commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers: JarTestCase.java ZipTestCase.java Date: Fri, 27 Mar 2009 20:45:00 -0000 To: commits@commons.apache.org From: sebb@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20090327204500.5B67123888AF@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: sebb Date: Fri Mar 27 20:44:59 2009 New Revision: 759338 URL: http://svn.apache.org/viewvc?rev=759338&view=rev Log: Close files Modified: commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/JarTestCase.java commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/ZipTestCase.java Modified: commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/JarTestCase.java URL: http://svn.apache.org/viewvc/commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/JarTestCase.java?rev=759338&r1=759337&r2=759338&view=diff ============================================================================== --- commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/JarTestCase.java (original) +++ commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/JarTestCase.java Fri Mar 27 20:44:59 2009 @@ -79,6 +79,7 @@ out.close(); in.close(); + is.close(); } public void testJarUnarchiveAll() throws Exception { @@ -102,6 +103,7 @@ } in.close(); + is.close(); } } Modified: commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/ZipTestCase.java URL: http://svn.apache.org/viewvc/commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/ZipTestCase.java?rev=759338&r1=759337&r2=759338&view=diff ============================================================================== --- commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/ZipTestCase.java (original) +++ commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/ZipTestCase.java Fri Mar 27 20:44:59 2009 @@ -57,10 +57,9 @@ } finally { if (os != null) { os.close(); - } else { - out.close(); } } + out.close(); // Unarchive the same List results = new ArrayList(); @@ -86,10 +85,9 @@ } finally { if (in != null) { in.close(); - } else { - is.close(); } } + is.close(); assertEquals(results.size(), 2); File result = (File)results.get(0);