Return-Path: Delivered-To: apmail-commons-commits-archive@minotaur.apache.org Received: (qmail 98092 invoked from network); 26 Mar 2009 20:55:11 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 26 Mar 2009 20:55:11 -0000 Received: (qmail 20195 invoked by uid 500); 26 Mar 2009 20:55:11 -0000 Delivered-To: apmail-commons-commits-archive@commons.apache.org Received: (qmail 20114 invoked by uid 500); 26 Mar 2009 20:55:10 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 20095 invoked by uid 99); 26 Mar 2009 20:55:10 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Mar 2009 20:55:10 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Mar 2009 20:55:08 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id C6B062388995; Thu, 26 Mar 2009 20:54:47 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r758850 - /commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/cpio/CpioArchiveEntry.java Date: Thu, 26 Mar 2009 20:54:47 -0000 To: commits@commons.apache.org From: sebb@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20090326205447.C6B062388995@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: sebb Date: Thu Mar 26 20:54:47 2009 New Revision: 758850 URL: http://svn.apache.org/viewvc?rev=758850&view=rev Log: COMPRESS-55 Throw error if user attempts to set an invalid mode Modified: commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/cpio/CpioArchiveEntry.java Modified: commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/cpio/CpioArchiveEntry.java URL: http://svn.apache.org/viewvc/commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/cpio/CpioArchiveEntry.java?rev=758850&r1=758849&r2=758850&view=diff ============================================================================== --- commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/cpio/CpioArchiveEntry.java (original) +++ commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/cpio/CpioArchiveEntry.java Thu Mar 26 20:54:47 2009 @@ -611,9 +611,7 @@ case C_ISNWK: break; default: - // FIXME: testCpioUnarchive fails if I change the line to - // actually throw the excpetion - new IllegalArgumentException( + throw new IllegalArgumentException( "Unknown mode. " + "Full: " + Long.toHexString(mode) + " Masked: " + Long.toHexString(maskedMode));