Return-Path: Delivered-To: apmail-commons-commits-archive@minotaur.apache.org Received: (qmail 48622 invoked from network); 14 Mar 2009 12:54:41 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 14 Mar 2009 12:54:41 -0000 Received: (qmail 62751 invoked by uid 500); 14 Mar 2009 12:54:40 -0000 Delivered-To: apmail-commons-commits-archive@commons.apache.org Received: (qmail 62687 invoked by uid 500); 14 Mar 2009 12:54:40 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 62678 invoked by uid 99); 14 Mar 2009 12:54:40 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 14 Mar 2009 05:54:40 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 14 Mar 2009 12:54:37 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 1AAAD23888F1; Sat, 14 Mar 2009 12:54:16 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r753645 - in /commons/proper/lang/trunk/src/java/org/apache/commons/lang: ./ builder/ Date: Sat, 14 Mar 2009 12:54:15 -0000 To: commits@commons.apache.org From: sebb@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20090314125416.1AAAD23888F1@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: sebb Date: Sat Mar 14 12:54:15 2009 New Revision: 753645 URL: http://svn.apache.org/viewvc?rev=753645&view=rev Log: Add missing @Override markers Modified: commons/proper/lang/trunk/src/java/org/apache/commons/lang/CharRange.java commons/proper/lang/trunk/src/java/org/apache/commons/lang/CharSet.java commons/proper/lang/trunk/src/java/org/apache/commons/lang/Entities.java commons/proper/lang/trunk/src/java/org/apache/commons/lang/NotImplementedException.java commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/HashCodeBuilder.java commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/IDKey.java commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/ReflectionToStringBuilder.java commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/StandardToStringStyle.java commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/ToStringBuilder.java commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/ToStringStyle.java Modified: commons/proper/lang/trunk/src/java/org/apache/commons/lang/CharRange.java URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/java/org/apache/commons/lang/CharRange.java?rev=753645&r1=753644&r2=753645&view=diff ============================================================================== --- commons/proper/lang/trunk/src/java/org/apache/commons/lang/CharRange.java (original) +++ commons/proper/lang/trunk/src/java/org/apache/commons/lang/CharRange.java Sat Mar 14 12:54:15 2009 @@ -185,6 +185,7 @@ * @param obj the object to compare to * @return true if equal */ + @Override public boolean equals(Object obj) { if (obj == this) { return true; @@ -201,6 +202,7 @@ * * @return a suitable hashCode */ + @Override public int hashCode() { return 83 + start + 7 * end + (negated ? 1 : 0); } @@ -210,6 +212,7 @@ * * @return string representation of this range */ + @Override public String toString() { if (iToString == null) { StringBuffer buf = new StringBuffer(4); Modified: commons/proper/lang/trunk/src/java/org/apache/commons/lang/CharSet.java URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/java/org/apache/commons/lang/CharSet.java?rev=753645&r1=753644&r2=753645&view=diff ============================================================================== --- commons/proper/lang/trunk/src/java/org/apache/commons/lang/CharSet.java (original) +++ commons/proper/lang/trunk/src/java/org/apache/commons/lang/CharSet.java Sat Mar 14 12:54:15 2009 @@ -265,6 +265,7 @@ * @return true if equal * @since 2.0 */ + @Override public boolean equals(Object obj) { if (obj == this) { return true; @@ -282,6 +283,7 @@ * @return a suitable hashCode * @since 2.0 */ + @Override public int hashCode() { return 89 + set.hashCode(); } @@ -291,6 +293,7 @@ * * @return string representation of the set */ + @Override public String toString() { return set.toString(); } Modified: commons/proper/lang/trunk/src/java/org/apache/commons/lang/Entities.java URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/java/org/apache/commons/lang/Entities.java?rev=753645&r1=753644&r2=753645&view=diff ============================================================================== --- commons/proper/lang/trunk/src/java/org/apache/commons/lang/Entities.java (original) +++ commons/proper/lang/trunk/src/java/org/apache/commons/lang/Entities.java Sat Mar 14 12:54:15 2009 @@ -529,6 +529,7 @@ /** * {@inheritDoc} */ + @Override public String name(int value) { if (value < LOOKUP_TABLE_SIZE) { return lookupTable()[value]; @@ -696,6 +697,7 @@ /** * {@inheritDoc} */ + @Override public void add(String name, int value) { ensureCapacity(size + 1); int insertAt = binarySearch(value); @@ -713,6 +715,7 @@ /** * {@inheritDoc} */ + @Override public String name(int value) { int index = binarySearch(value); if (index < 0) { Modified: commons/proper/lang/trunk/src/java/org/apache/commons/lang/NotImplementedException.java URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/java/org/apache/commons/lang/NotImplementedException.java?rev=753645&r1=753644&r2=753645&view=diff ============================================================================== --- commons/proper/lang/trunk/src/java/org/apache/commons/lang/NotImplementedException.java (original) +++ commons/proper/lang/trunk/src/java/org/apache/commons/lang/NotImplementedException.java Sat Mar 14 12:54:15 2009 @@ -134,6 +134,7 @@ * * @since 2.1 */ + @Override public Throwable getCause() { return cause; } @@ -144,6 +145,7 @@ * @return the error message * @since 2.1 */ + @Override public String getMessage() { if (super.getMessage() != null) { return super.getMessage(); @@ -255,6 +257,7 @@ * * @since 2.1 */ + @Override public void printStackTrace() { delegate.printStackTrace(); } @@ -266,6 +269,7 @@ * @param out the stream to write to * @since 2.1 */ + @Override public void printStackTrace(PrintStream out) { delegate.printStackTrace(out); } @@ -277,6 +281,7 @@ * @param out the writer to write to * @since 2.1 */ + @Override public void printStackTrace(PrintWriter out) { delegate.printStackTrace(out); } Modified: commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/HashCodeBuilder.java URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/HashCodeBuilder.java?rev=753645&r1=753644&r2=753645&view=diff ============================================================================== --- commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/HashCodeBuilder.java (original) +++ commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/HashCodeBuilder.java Sat Mar 14 12:54:15 2009 @@ -103,6 +103,7 @@ * @since 2.3 */ private static ThreadLocal registry = new ThreadLocal() { + @Override protected Object initialValue() { // The HashSet implementation is not synchronized, // which is just what we need here. Modified: commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/IDKey.java URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/IDKey.java?rev=753645&r1=753644&r2=753645&view=diff ============================================================================== --- commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/IDKey.java (original) +++ commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/IDKey.java Sat Mar 14 12:54:15 2009 @@ -49,6 +49,7 @@ * returns hashcode - i.e. the system identity hashcode. * @return the hashcode */ + @Override public int hashCode() { return id; } @@ -58,6 +59,7 @@ * @param other * @return if the instances are for the same object */ + @Override public boolean equals(Object other) { if (!(other instanceof IDKey)) { return false; Modified: commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/ReflectionToStringBuilder.java URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/ReflectionToStringBuilder.java?rev=753645&r1=753644&r2=753645&view=diff ============================================================================== --- commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/ReflectionToStringBuilder.java (original) +++ commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/ReflectionToStringBuilder.java Sat Mar 14 12:54:15 2009 @@ -751,6 +751,7 @@ * * @return the built string */ + @Override public String toString() { if (this.getObject() == null) { return this.getStyle().getNullText(); Modified: commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/StandardToStringStyle.java URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/StandardToStringStyle.java?rev=753645&r1=753644&r2=753645&view=diff ============================================================================== --- commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/StandardToStringStyle.java (original) +++ commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/StandardToStringStyle.java Sat Mar 14 12:54:15 2009 @@ -54,6 +54,7 @@ * * @return the current useClassName flag */ + @Override public boolean isUseClassName() { return super.isUseClassName(); } @@ -63,6 +64,7 @@ * * @param useClassName the new useClassName flag */ + @Override public void setUseClassName(boolean useClassName) { super.setUseClassName(useClassName); } @@ -75,6 +77,7 @@ * @return the current useShortClassName flag * @since 2.0 */ + @Override public boolean isUseShortClassName() { return super.isUseShortClassName(); } @@ -86,6 +89,7 @@ * @deprecated Use {@link #isUseShortClassName()} * Method will be removed in Commons Lang 3.0. */ + @Override public boolean isShortClassName() { return super.isUseShortClassName(); } @@ -96,6 +100,7 @@ * @param useShortClassName the new useShortClassName flag * @since 2.0 */ + @Override public void setUseShortClassName(boolean useShortClassName) { super.setUseShortClassName(useShortClassName); } @@ -107,6 +112,7 @@ * @deprecated Use {@link #setUseShortClassName(boolean)} * Method will be removed in Commons Lang 3.0. */ + @Override public void setShortClassName(boolean shortClassName) { super.setUseShortClassName(shortClassName); } @@ -117,6 +123,7 @@ *

Gets whether to use the identity hash code.

* @return the current useIdentityHashCode flag */ + @Override public boolean isUseIdentityHashCode() { return super.isUseIdentityHashCode(); } @@ -126,6 +133,7 @@ * * @param useIdentityHashCode the new useIdentityHashCode flag */ + @Override public void setUseIdentityHashCode(boolean useIdentityHashCode) { super.setUseIdentityHashCode(useIdentityHashCode); } @@ -137,6 +145,7 @@ * * @return the current useFieldNames flag */ + @Override public boolean isUseFieldNames() { return super.isUseFieldNames(); } @@ -146,6 +155,7 @@ * * @param useFieldNames the new useFieldNames flag */ + @Override public void setUseFieldNames(boolean useFieldNames) { super.setUseFieldNames(useFieldNames); } @@ -158,6 +168,7 @@ * * @return the current defaultFullDetail flag */ + @Override public boolean isDefaultFullDetail() { return super.isDefaultFullDetail(); } @@ -168,6 +179,7 @@ * * @param defaultFullDetail the new defaultFullDetail flag */ + @Override public void setDefaultFullDetail(boolean defaultFullDetail) { super.setDefaultFullDetail(defaultFullDetail); } @@ -179,6 +191,7 @@ * * @return the current array content detail setting */ + @Override public boolean isArrayContentDetail() { return super.isArrayContentDetail(); } @@ -188,6 +201,7 @@ * * @param arrayContentDetail the new arrayContentDetail flag */ + @Override public void setArrayContentDetail(boolean arrayContentDetail) { super.setArrayContentDetail(arrayContentDetail); } @@ -199,6 +213,7 @@ * * @return the current array start text */ + @Override public String getArrayStart() { return super.getArrayStart(); } @@ -211,6 +226,7 @@ * * @param arrayStart the new array start text */ + @Override public void setArrayStart(String arrayStart) { super.setArrayStart(arrayStart); } @@ -222,6 +238,7 @@ * * @return the current array end text */ + @Override public String getArrayEnd() { return super.getArrayEnd(); } @@ -234,6 +251,7 @@ * * @param arrayEnd the new array end text */ + @Override public void setArrayEnd(String arrayEnd) { super.setArrayEnd(arrayEnd); } @@ -245,6 +263,7 @@ * * @return the current array separator text */ + @Override public String getArraySeparator() { return super.getArraySeparator(); } @@ -257,6 +276,7 @@ * * @param arraySeparator the new array separator text */ + @Override public void setArraySeparator(String arraySeparator) { super.setArraySeparator(arraySeparator); } @@ -268,6 +288,7 @@ * * @return the current content start text */ + @Override public String getContentStart() { return super.getContentStart(); } @@ -280,6 +301,7 @@ * * @param contentStart the new content start text */ + @Override public void setContentStart(String contentStart) { super.setContentStart(contentStart); } @@ -291,6 +313,7 @@ * * @return the current content end text */ + @Override public String getContentEnd() { return super.getContentEnd(); } @@ -303,6 +326,7 @@ * * @param contentEnd the new content end text */ + @Override public void setContentEnd(String contentEnd) { super.setContentEnd(contentEnd); } @@ -314,6 +338,7 @@ * * @return the current field name value separator text */ + @Override public String getFieldNameValueSeparator() { return super.getFieldNameValueSeparator(); } @@ -326,6 +351,7 @@ * * @param fieldNameValueSeparator the new field name value separator text */ + @Override public void setFieldNameValueSeparator(String fieldNameValueSeparator) { super.setFieldNameValueSeparator(fieldNameValueSeparator); } @@ -337,6 +363,7 @@ * * @return the current field separator text */ + @Override public String getFieldSeparator() { return super.getFieldSeparator(); } @@ -349,6 +376,7 @@ * * @param fieldSeparator the new field separator text */ + @Override public void setFieldSeparator(String fieldSeparator) { super.setFieldSeparator(fieldSeparator); } @@ -362,6 +390,7 @@ * @return the fieldSeparatorAtStart flag * @since 2.0 */ + @Override public boolean isFieldSeparatorAtStart() { return super.isFieldSeparatorAtStart(); } @@ -373,6 +402,7 @@ * @param fieldSeparatorAtStart the fieldSeparatorAtStart flag * @since 2.0 */ + @Override public void setFieldSeparatorAtStart(boolean fieldSeparatorAtStart) { super.setFieldSeparatorAtStart(fieldSeparatorAtStart); } @@ -386,6 +416,7 @@ * @return fieldSeparatorAtEnd flag * @since 2.0 */ + @Override public boolean isFieldSeparatorAtEnd() { return super.isFieldSeparatorAtEnd(); } @@ -397,6 +428,7 @@ * @param fieldSeparatorAtEnd the fieldSeparatorAtEnd flag * @since 2.0 */ + @Override public void setFieldSeparatorAtEnd(boolean fieldSeparatorAtEnd) { super.setFieldSeparatorAtEnd(fieldSeparatorAtEnd); } @@ -408,6 +440,7 @@ * * @return the current text to output when null found */ + @Override public String getNullText() { return super.getNullText(); } @@ -420,6 +453,7 @@ * * @param nullText the new text to output when null found */ + @Override public void setNullText(String nullText) { super.setNullText(nullText); } @@ -434,6 +468,7 @@ * * @return the current start of size text */ + @Override public String getSizeStartText() { return super.getSizeStartText(); } @@ -449,6 +484,7 @@ * * @param sizeStartText the new start of size text */ + @Override public void setSizeStartText(String sizeStartText) { super.setSizeStartText(sizeStartText); } @@ -463,6 +499,7 @@ * * @return the current end of size text */ + @Override public String getSizeEndText() { return super.getSizeEndText(); } @@ -478,6 +515,7 @@ * * @param sizeEndText the new end of size text */ + @Override public void setSizeEndText(String sizeEndText) { super.setSizeEndText(sizeEndText); } @@ -492,6 +530,7 @@ * * @return the current start of summary text */ + @Override public String getSummaryObjectStartText() { return super.getSummaryObjectStartText(); } @@ -507,6 +546,7 @@ * * @param summaryObjectStartText the new start of summary text */ + @Override public void setSummaryObjectStartText(String summaryObjectStartText) { super.setSummaryObjectStartText(summaryObjectStartText); } @@ -521,6 +561,7 @@ * * @return the current end of summary text */ + @Override public String getSummaryObjectEndText() { return super.getSummaryObjectEndText(); } @@ -536,6 +577,7 @@ * * @param summaryObjectEndText the new end of summary text */ + @Override public void setSummaryObjectEndText(String summaryObjectEndText) { super.setSummaryObjectEndText(summaryObjectEndText); } Modified: commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/ToStringBuilder.java URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/ToStringBuilder.java?rev=753645&r1=753644&r2=753645&view=diff ============================================================================== --- commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/ToStringBuilder.java (original) +++ commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/ToStringBuilder.java Sat Mar 14 12:54:15 2009 @@ -1045,6 +1045,7 @@ * * @return the String toString */ + @Override public String toString() { if (this.getObject() == null) { this.getStringBuffer().append(this.getStyle().getNullText()); Modified: commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/ToStringStyle.java URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/ToStringStyle.java?rev=753645&r1=753644&r2=753645&view=diff ============================================================================== --- commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/ToStringStyle.java (original) +++ commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/ToStringStyle.java Sat Mar 14 12:54:15 2009 @@ -134,6 +134,7 @@ *

*/ private static ThreadLocal registry = new ThreadLocal() { + @Override protected Object initialValue() { // The HashSet implementation is not synchronized, // which is just what we need here.