Return-Path: Delivered-To: apmail-commons-commits-archive@minotaur.apache.org Received: (qmail 50933 invoked from network); 28 Feb 2009 20:10:59 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 28 Feb 2009 20:10:59 -0000 Received: (qmail 23280 invoked by uid 500); 28 Feb 2009 20:10:58 -0000 Delivered-To: apmail-commons-commits-archive@commons.apache.org Received: (qmail 23002 invoked by uid 500); 28 Feb 2009 20:10:57 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 22993 invoked by uid 99); 28 Feb 2009 20:10:57 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 28 Feb 2009 12:10:57 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 28 Feb 2009 20:10:50 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id D3E3323888A5; Sat, 28 Feb 2009 20:10:29 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r748915 - in /commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils: ./ handlers/ wrappers/ Date: Sat, 28 Feb 2009 20:10:29 -0000 To: commits@commons.apache.org From: bayard@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20090228201029.D3E3323888A5@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: bayard Date: Sat Feb 28 20:10:28 2009 New Revision: 748915 URL: http://svn.apache.org/viewvc?rev=748915&view=rev Log: Removing unnecessary (String) constructor in JUnit classes Modified: commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/BaseTestCase.java commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/BasicRowProcessorTest.java commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/BeanProcessorTest.java commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/ProxyFactoryTest.java commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/QueryLoaderTest.java commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/ResultSetIteratorTest.java commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/handlers/ArrayHandlerTest.java commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/handlers/ArrayListHandlerTest.java commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/handlers/BeanHandlerTest.java commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/handlers/BeanListHandlerTest.java commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/handlers/ColumnListHandlerTest.java commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/handlers/KeyedHandlerTest.java commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/handlers/MapHandlerTest.java commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/handlers/MapListHandlerTest.java commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/handlers/ScalarHandlerTest.java commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/wrappers/SqlNullCheckedResultSetTest.java commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/wrappers/StringTrimmedResultSetTest.java Modified: commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/BaseTestCase.java URL: http://svn.apache.org/viewvc/commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/BaseTestCase.java?rev=748915&r1=748914&r2=748915&view=diff ============================================================================== --- commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/BaseTestCase.java (original) +++ commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/BaseTestCase.java Sat Feb 28 20:10:28 2009 @@ -108,13 +108,6 @@ protected ResultSet emptyResultSet = null; /** - * Constructor for BaseTestCase. - */ - public BaseTestCase(String name) { - super(name); - } - - /** * This is called before each test method so ResultSet will be fresh each * time. * @see junit.framework.TestCase#setUp() Modified: commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/BasicRowProcessorTest.java URL: http://svn.apache.org/viewvc/commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/BasicRowProcessorTest.java?rev=748915&r1=748914&r2=748915&view=diff ============================================================================== --- commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/BasicRowProcessorTest.java (original) +++ commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/BasicRowProcessorTest.java Sat Feb 28 20:10:28 2009 @@ -38,14 +38,6 @@ private static final DateFormat datef = new SimpleDateFormat("EEE MMM dd HH:mm:ss zzz yyyy", Locale.US); - /** - * Constructor for BasicRowProcessorTest. - * @param name - */ - public BasicRowProcessorTest(String name) { - super(name); - } - public void testToArray() throws SQLException { int rowCount = 0; Modified: commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/BeanProcessorTest.java URL: http://svn.apache.org/viewvc/commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/BeanProcessorTest.java?rev=748915&r1=748914&r2=748915&view=diff ============================================================================== --- commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/BeanProcessorTest.java (original) +++ commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/BeanProcessorTest.java Sat Feb 28 20:10:28 2009 @@ -22,10 +22,6 @@ private static final BeanProcessor beanProc = new BeanProcessor(); - public BeanProcessorTest(String name) { - super(name); - } - public void testProcess() throws SQLException { int rowCount = 0; TestBean b = null; Modified: commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/ProxyFactoryTest.java URL: http://svn.apache.org/viewvc/commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/ProxyFactoryTest.java?rev=748915&r1=748914&r2=748915&view=diff ============================================================================== --- commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/ProxyFactoryTest.java (original) +++ commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/ProxyFactoryTest.java Sat Feb 28 20:10:28 2009 @@ -41,13 +41,6 @@ } }; - /** - * Constructor for ProxyFactoryTest. - */ - public ProxyFactoryTest(String name) { - super(name); - } - public void testCreateConnection() { assertTrue( ProxyFactory.instance().createConnection(stub) Modified: commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/QueryLoaderTest.java URL: http://svn.apache.org/viewvc/commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/QueryLoaderTest.java?rev=748915&r1=748914&r2=748915&view=diff ============================================================================== --- commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/QueryLoaderTest.java (original) +++ commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/QueryLoaderTest.java Sat Feb 28 20:10:28 2009 @@ -27,13 +27,6 @@ private static final String QUERIES = "/org/apache/commons/dbutils/TestQueries.properties"; - /** - * Constructor for QueryLoaderTest. - */ - public QueryLoaderTest(String name) { - super(name); - } - public void testLoad() throws IOException { try { QueryLoader loader = QueryLoader.instance(); Modified: commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/ResultSetIteratorTest.java URL: http://svn.apache.org/viewvc/commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/ResultSetIteratorTest.java?rev=748915&r1=748914&r2=748915&view=diff ============================================================================== --- commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/ResultSetIteratorTest.java (original) +++ commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/ResultSetIteratorTest.java Sat Feb 28 20:10:28 2009 @@ -23,14 +23,6 @@ */ public class ResultSetIteratorTest extends BaseTestCase { - /** - * Constructor for ResultSetIteratorTest. - * @param arg0 - */ - public ResultSetIteratorTest(String arg0) { - super(arg0); - } - public void testNext() { Iterator iter = new ResultSetIterator(this.rs); Modified: commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/handlers/ArrayHandlerTest.java URL: http://svn.apache.org/viewvc/commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/handlers/ArrayHandlerTest.java?rev=748915&r1=748914&r2=748915&view=diff ============================================================================== --- commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/handlers/ArrayHandlerTest.java (original) +++ commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/handlers/ArrayHandlerTest.java Sat Feb 28 20:10:28 2009 @@ -26,13 +26,6 @@ */ public class ArrayHandlerTest extends BaseTestCase { - /** - * Constructor for ArrayHandlerTest. - */ - public ArrayHandlerTest(String name) { - super(name); - } - public void testHandle() throws SQLException { ResultSetHandler h = new ArrayHandler(); Object[] results = (Object[]) h.handle(this.rs); Modified: commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/handlers/ArrayListHandlerTest.java URL: http://svn.apache.org/viewvc/commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/handlers/ArrayListHandlerTest.java?rev=748915&r1=748914&r2=748915&view=diff ============================================================================== --- commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/handlers/ArrayListHandlerTest.java (original) +++ commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/handlers/ArrayListHandlerTest.java Sat Feb 28 20:10:28 2009 @@ -28,13 +28,6 @@ */ public class ArrayListHandlerTest extends BaseTestCase { - /** - * Constructor for ArrayListHandlerTest. - */ - public ArrayListHandlerTest(String name) { - super(name); - } - public void testHandle() throws SQLException { ResultSetHandler h = new ArrayListHandler(); List results = (List) h.handle(this.rs); Modified: commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/handlers/BeanHandlerTest.java URL: http://svn.apache.org/viewvc/commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/handlers/BeanHandlerTest.java?rev=748915&r1=748914&r2=748915&view=diff ============================================================================== --- commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/handlers/BeanHandlerTest.java (original) +++ commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/handlers/BeanHandlerTest.java Sat Feb 28 20:10:28 2009 @@ -27,13 +27,6 @@ */ public class BeanHandlerTest extends BaseTestCase { - /** - * Constructor for BeanHandlerTest. - */ - public BeanHandlerTest(String name) { - super(name); - } - public void testHandle() throws SQLException { ResultSetHandler h = new BeanHandler(TestBean.class); TestBean results = (TestBean) h.handle(this.rs); Modified: commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/handlers/BeanListHandlerTest.java URL: http://svn.apache.org/viewvc/commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/handlers/BeanListHandlerTest.java?rev=748915&r1=748914&r2=748915&view=diff ============================================================================== --- commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/handlers/BeanListHandlerTest.java (original) +++ commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/handlers/BeanListHandlerTest.java Sat Feb 28 20:10:28 2009 @@ -29,13 +29,6 @@ */ public class BeanListHandlerTest extends BaseTestCase { - /** - * Constructor for BeanListHandlerTest. - */ - public BeanListHandlerTest(String name) { - super(name); - } - public void testHandle() throws SQLException { ResultSetHandler h = new BeanListHandler(TestBean.class); List results = (List) h.handle(this.rs); Modified: commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/handlers/ColumnListHandlerTest.java URL: http://svn.apache.org/viewvc/commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/handlers/ColumnListHandlerTest.java?rev=748915&r1=748914&r2=748915&view=diff ============================================================================== --- commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/handlers/ColumnListHandlerTest.java (original) +++ commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/handlers/ColumnListHandlerTest.java Sat Feb 28 20:10:28 2009 @@ -27,10 +27,6 @@ */ public class ColumnListHandlerTest extends BaseTestCase { - public ColumnListHandlerTest(String name) { - super(name); - } - public void testHandle() throws SQLException { ResultSetHandler h = new ColumnListHandler(); Modified: commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/handlers/KeyedHandlerTest.java URL: http://svn.apache.org/viewvc/commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/handlers/KeyedHandlerTest.java?rev=748915&r1=748914&r2=748915&view=diff ============================================================================== --- commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/handlers/KeyedHandlerTest.java (original) +++ commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/handlers/KeyedHandlerTest.java Sat Feb 28 20:10:28 2009 @@ -25,10 +25,6 @@ public class KeyedHandlerTest extends BaseTestCase { - public KeyedHandlerTest(String name) { - super(name); - } - public void testHandle() throws SQLException { ResultSetHandler h = new KeyedHandler(); @@ -105,4 +101,4 @@ assertNotNull(results); assertTrue(results.isEmpty()); } -} \ No newline at end of file +} Modified: commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/handlers/MapHandlerTest.java URL: http://svn.apache.org/viewvc/commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/handlers/MapHandlerTest.java?rev=748915&r1=748914&r2=748915&view=diff ============================================================================== --- commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/handlers/MapHandlerTest.java (original) +++ commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/handlers/MapHandlerTest.java Sat Feb 28 20:10:28 2009 @@ -27,13 +27,6 @@ */ public class MapHandlerTest extends BaseTestCase { - /** - * Constructor for MapHandlerTest. - */ - public MapHandlerTest(String name) { - super(name); - } - public void testHandle() throws SQLException { ResultSetHandler h = new MapHandler(); Map results = (Map) h.handle(this.rs); Modified: commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/handlers/MapListHandlerTest.java URL: http://svn.apache.org/viewvc/commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/handlers/MapListHandlerTest.java?rev=748915&r1=748914&r2=748915&view=diff ============================================================================== --- commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/handlers/MapListHandlerTest.java (original) +++ commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/handlers/MapListHandlerTest.java Sat Feb 28 20:10:28 2009 @@ -29,13 +29,6 @@ */ public class MapListHandlerTest extends BaseTestCase { - /** - * Constructor for MapListHandlerTest. - */ - public MapListHandlerTest(String name) { - super(name); - } - public void testHandle() throws SQLException { ResultSetHandler h = new MapListHandler(); List results = (List) h.handle(this.rs); Modified: commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/handlers/ScalarHandlerTest.java URL: http://svn.apache.org/viewvc/commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/handlers/ScalarHandlerTest.java?rev=748915&r1=748914&r2=748915&view=diff ============================================================================== --- commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/handlers/ScalarHandlerTest.java (original) +++ commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/handlers/ScalarHandlerTest.java Sat Feb 28 20:10:28 2009 @@ -23,10 +23,6 @@ public class ScalarHandlerTest extends BaseTestCase { - public ScalarHandlerTest(String name) { - super(name); - } - public void testHandle() throws SQLException { ResultSetHandler h = new ScalarHandler(); Object results = h.handle(this.rs); @@ -54,4 +50,4 @@ assertNull(results); } -} \ No newline at end of file +} Modified: commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/wrappers/SqlNullCheckedResultSetTest.java URL: http://svn.apache.org/viewvc/commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/wrappers/SqlNullCheckedResultSetTest.java?rev=748915&r1=748914&r2=748915&view=diff ============================================================================== --- commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/wrappers/SqlNullCheckedResultSetTest.java (original) +++ commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/wrappers/SqlNullCheckedResultSetTest.java Sat Feb 28 20:10:28 2009 @@ -50,17 +50,6 @@ private SqlNullCheckedResultSet rs2 = null; /** - * Constructs a new instance of - * SqlNullCheckedResultSetTestCase - * with the specified name. - * - * @param name the test case name - */ - public SqlNullCheckedResultSetTest(String name) { - super(name); - } - - /** * Sets up instance variables required by this test case. */ public void setUp() throws Exception { Modified: commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/wrappers/StringTrimmedResultSetTest.java URL: http://svn.apache.org/viewvc/commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/wrappers/StringTrimmedResultSetTest.java?rev=748915&r1=748914&r2=748915&view=diff ============================================================================== --- commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/wrappers/StringTrimmedResultSetTest.java (original) +++ commons/proper/dbutils/trunk/src/test/org/apache/commons/dbutils/wrappers/StringTrimmedResultSetTest.java Sat Feb 28 20:10:28 2009 @@ -28,10 +28,6 @@ */ public class StringTrimmedResultSetTest extends BaseTestCase { - public StringTrimmedResultSetTest(String name) { - super(name); - } - public void setUp() throws Exception { super.setUp(); this.rs = StringTrimmedResultSet.wrap(this.rs);