commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject svn commit: r732438 - in /commons/proper/scxml/branches/J6/src/main/java/org/apache/commons/scxml: env/javascript/JSBindings.java env/javascript/JSEvaluator.java io/SCXMLParser.java
Date Wed, 07 Jan 2009 19:30:02 GMT
Author: sebb
Date: Wed Jan  7 11:30:02 2009
New Revision: 732438

URL: http://svn.apache.org/viewvc?rev=732438&view=rev
Log:
Remove unnecessary @SuppressWarnings("unchecked") annotations
and an unused import

Modified:
    commons/proper/scxml/branches/J6/src/main/java/org/apache/commons/scxml/env/javascript/JSBindings.java
    commons/proper/scxml/branches/J6/src/main/java/org/apache/commons/scxml/env/javascript/JSEvaluator.java
    commons/proper/scxml/branches/J6/src/main/java/org/apache/commons/scxml/io/SCXMLParser.java

Modified: commons/proper/scxml/branches/J6/src/main/java/org/apache/commons/scxml/env/javascript/JSBindings.java
URL: http://svn.apache.org/viewvc/commons/proper/scxml/branches/J6/src/main/java/org/apache/commons/scxml/env/javascript/JSBindings.java?rev=732438&r1=732437&r2=732438&view=diff
==============================================================================
--- commons/proper/scxml/branches/J6/src/main/java/org/apache/commons/scxml/env/javascript/JSBindings.java
(original)
+++ commons/proper/scxml/branches/J6/src/main/java/org/apache/commons/scxml/env/javascript/JSBindings.java
Wed Jan  7 11:30:02 2009
@@ -52,7 +52,6 @@
      *         or <code>bindings</code> is <code>null</code>.
      *
      */
-    @SuppressWarnings("unchecked")
     public JSBindings(Context context,Bindings bindings) {
         // ... validate
 
@@ -93,7 +92,6 @@
      * NOTE: doesn't seem to be invoked ever. Not thread-safe.
      *
      */
-    @SuppressWarnings("unchecked")
     @Override
     public Set<String> keySet() {
         Set<String> keys = new HashSet<String>();
@@ -112,7 +110,6 @@
      *       context. Not thread-safe.
      *
      */
-    @SuppressWarnings("unchecked")
     @Override
     public int size() {
         Set<String> keys = new HashSet<String>();
@@ -145,7 +142,6 @@
      * NOTE: doesn't seem to be invoked ever so not sure if it works in
      *       context. Not thread-safe.
      */
-    @SuppressWarnings("unchecked")
     @Override
     public Set<Map.Entry<String,Object>> entrySet() {
         return union().entrySet();
@@ -158,7 +154,6 @@
      * NOTE: doesn't seem to be invoked ever so not sure if it works in
      *       context. Not thread-safe.
      */
-    @SuppressWarnings("unchecked")
     @Override
     public Collection<Object> values() {
         return union().values();
@@ -265,7 +260,6 @@
      * Bindings. Does a heavyweight copy - and so far only invoked by the
      * not used methods.
      */
-    @SuppressWarnings("unchecked")
     private Bindings union() {
         Bindings set = new SimpleBindings();
 

Modified: commons/proper/scxml/branches/J6/src/main/java/org/apache/commons/scxml/env/javascript/JSEvaluator.java
URL: http://svn.apache.org/viewvc/commons/proper/scxml/branches/J6/src/main/java/org/apache/commons/scxml/env/javascript/JSEvaluator.java?rev=732438&r1=732437&r2=732438&view=diff
==============================================================================
--- commons/proper/scxml/branches/J6/src/main/java/org/apache/commons/scxml/env/javascript/JSEvaluator.java
(original)
+++ commons/proper/scxml/branches/J6/src/main/java/org/apache/commons/scxml/env/javascript/JSEvaluator.java
Wed Jan  7 11:30:02 2009
@@ -25,8 +25,6 @@
 import javax.script.ScriptContext;
 import javax.script.ScriptEngine;
 import javax.script.ScriptEngineManager;
-import javax.script.ScriptException;
-
 import org.apache.commons.scxml.Builtin;
 import org.apache.commons.scxml.Context;
 import org.apache.commons.scxml.Evaluator;
@@ -105,7 +103,6 @@
      *
      * @throws SCXMLExpressionException Thrown if the expression was invalid.
      */
-    @SuppressWarnings("unchecked")
     @Override
     public Object eval(Context context,String expression) throws SCXMLExpressionException
{
         try {
@@ -171,7 +168,6 @@
      *
      * @throws SCXMLExpressionException Thrown if the expression was invalid.
      */
-    @SuppressWarnings("unchecked")
     @Override
     public Node evalLocation(Context context,String expression) throws SCXMLExpressionException
{
         try {

Modified: commons/proper/scxml/branches/J6/src/main/java/org/apache/commons/scxml/io/SCXMLParser.java
URL: http://svn.apache.org/viewvc/commons/proper/scxml/branches/J6/src/main/java/org/apache/commons/scxml/io/SCXMLParser.java?rev=732438&r1=732437&r2=732438&view=diff
==============================================================================
--- commons/proper/scxml/branches/J6/src/main/java/org/apache/commons/scxml/io/SCXMLParser.java
(original)
+++ commons/proper/scxml/branches/J6/src/main/java/org/apache/commons/scxml/io/SCXMLParser.java
Wed Jan  7 11:30:02 2009
@@ -1708,8 +1708,6 @@
          * @see Rule#begin(String, String, Attributes)
          */
         @Override
-        @SuppressWarnings("unchecked")
-        // Accomodate legacy code org.apache.commons.digester.Digester#getCurrentNamespaces()
         public final void begin(final String namespace, final String name,
                 final Attributes attributes) {
             NamespacePrefixesHolder nsHolder =



Mime
View raw message