commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject svn commit: r674299 - /commons/sandbox/compress/trunk/src/java/org/apache/commons/compress/archivers/zip/ZipEntry.java
Date Sun, 06 Jul 2008 13:23:32 GMT
Author: sebb
Date: Sun Jul  6 06:23:32 2008
New Revision: 674299

URL: http://svn.apache.org/viewvc?rev=674299&view=rev
Log:
clone() is not allowed to return null

Modified:
    commons/sandbox/compress/trunk/src/java/org/apache/commons/compress/archivers/zip/ZipEntry.java

Modified: commons/sandbox/compress/trunk/src/java/org/apache/commons/compress/archivers/zip/ZipEntry.java
URL: http://svn.apache.org/viewvc/commons/sandbox/compress/trunk/src/java/org/apache/commons/compress/archivers/zip/ZipEntry.java?rev=674299&r1=674298&r2=674299&view=diff
==============================================================================
--- commons/sandbox/compress/trunk/src/java/org/apache/commons/compress/archivers/zip/ZipEntry.java
(original)
+++ commons/sandbox/compress/trunk/src/java/org/apache/commons/compress/archivers/zip/ZipEntry.java
Sun Jul  6 06:23:32 2008
@@ -405,8 +405,7 @@
         catch( final Exception e )
         {
             // impossible as extra data is in correct format
-            e.printStackTrace();
-            return null;
+            throw new Error("Should never happen");// TODO replace with AssertionError? (1.4+)
         }
 
         entry.setInternalAttributes( getInternalAttributes() );



Mime
View raw message