Return-Path: Delivered-To: apmail-commons-commits-archive@locus.apache.org Received: (qmail 82648 invoked from network); 19 Jun 2008 20:16:03 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 19 Jun 2008 20:16:03 -0000 Received: (qmail 98182 invoked by uid 500); 19 Jun 2008 20:16:05 -0000 Delivered-To: apmail-commons-commits-archive@commons.apache.org Received: (qmail 97753 invoked by uid 500); 19 Jun 2008 20:16:04 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 97744 invoked by uid 99); 19 Jun 2008 20:16:04 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Jun 2008 13:16:04 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Jun 2008 20:15:23 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id EEEC02388A16; Thu, 19 Jun 2008 13:15:11 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r669672 - /commons/proper/codec/trunk/src/test/org/apache/commons/codec/binary/Base64Test.java Date: Thu, 19 Jun 2008 20:15:11 -0000 To: commits@commons.apache.org From: sebb@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20080619201511.EEEC02388A16@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: sebb Date: Thu Jun 19 13:15:11 2008 New Revision: 669672 URL: http://svn.apache.org/viewvc?rev=669672&view=rev Log: A few more tests Modified: commons/proper/codec/trunk/src/test/org/apache/commons/codec/binary/Base64Test.java Modified: commons/proper/codec/trunk/src/test/org/apache/commons/codec/binary/Base64Test.java URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/test/org/apache/commons/codec/binary/Base64Test.java?rev=669672&r1=669671&r2=669672&view=diff ============================================================================== --- commons/proper/codec/trunk/src/test/org/apache/commons/codec/binary/Base64Test.java (original) +++ commons/proper/codec/trunk/src/test/org/apache/commons/codec/binary/Base64Test.java Thu Jun 19 13:15:11 2008 @@ -523,6 +523,9 @@ assertFalse(Base64.isArrayByteBase64(new byte[] {Byte.MAX_VALUE})); assertTrue(Base64.isArrayByteBase64(new byte[] {'A'})); assertFalse(Base64.isArrayByteBase64(new byte[] {'A', Byte.MIN_VALUE})); + assertTrue(Base64.isArrayByteBase64(new byte[] {'A', 'Z', 'a'})); + assertTrue(Base64.isArrayByteBase64(new byte[] {'/','=','+'})); + assertFalse(Base64.isArrayByteBase64(new byte[] {'$'})); } public void testObjectDecodeWithInvalidParameter() throws Exception { @@ -531,7 +534,7 @@ Base64 b64 = new Base64(); try { - Object o = new String( "Yadayadayada" ); + Object o = "Yadayadayada"; b64.decode( o ); } catch( Exception e ) { exceptionThrown = true; @@ -545,7 +548,7 @@ String original = "Hello World!"; byte[] bArray = - Base64.encodeBase64( (new String(original)).getBytes() ); + Base64.encodeBase64(original.getBytes() ); Object o = bArray; Base64 b64 = new Base64(); @@ -563,7 +566,7 @@ Base64 b64 = new Base64(); try { - Object o = new String( "Yadayadayada" ); + Object o = "Yadayadayada"; b64.encode( o ); } catch( Exception e ) { exceptionThrown = true; @@ -607,7 +610,7 @@ String dest = new String( decodedWithWS ); - assertTrue( "Dest string doesn't equals the original", + assertTrue( "Dest string doesn't equal the original", dest.equals( orig ) ); } @@ -632,9 +635,9 @@ String destFromWS = new String( decodedWithWS ); String destFromNoWS = new String( decodedNoWS ); - assertTrue( "Dest string doesn't eausl original", + assertTrue( "Dest string doesn't equal original", destFromWS.equals( orig ) ); - assertTrue( "Dest string doesn't eausl original", + assertTrue( "Dest string doesn't equal original", destFromNoWS.equals( orig ) ); }