commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mben...@apache.org
Subject svn commit: r652925 - in /commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath: BasicVariables.java Container.java Variables.java ri/QName.java servlet/KeywordVariables.java xml/DocumentContainer.java
Date Fri, 02 May 2008 22:05:41 GMT
Author: mbenson
Date: Fri May  2 15:05:41 2008
New Revision: 652925

URL: http://svn.apache.org/viewvc?rev=652925&view=rev
Log:
improve serialization support; findbugs

Modified:
    commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/BasicVariables.java
    commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/Container.java
    commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/Variables.java
    commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/QName.java
    commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/servlet/KeywordVariables.java
    commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/xml/DocumentContainer.java

Modified: commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/BasicVariables.java
URL: http://svn.apache.org/viewvc/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/BasicVariables.java?rev=652925&r1=652924&r2=652925&view=diff
==============================================================================
--- commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/BasicVariables.java (original)
+++ commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/BasicVariables.java Fri
May  2 15:05:41 2008
@@ -25,6 +25,7 @@
  * @version $Revision$ $Date$
  */
 public class BasicVariables implements Variables {
+    private static final long serialVersionUID = 2708263960832062725L;
 
     /**
      * Contains the values of declared variables

Modified: commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/Container.java
URL: http://svn.apache.org/viewvc/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/Container.java?rev=652925&r1=652924&r2=652925&view=diff
==============================================================================
--- commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/Container.java (original)
+++ commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/Container.java Fri May
 2 15:05:41 2008
@@ -16,6 +16,8 @@
  */
 package org.apache.commons.jxpath;
 
+import java.io.Serializable;
+
 /**
  * A Container is an object implementing an indirection
  * mechanism transparent to JXPath.  For example, if property
@@ -26,7 +28,7 @@
  * @author Dmitri Plotnikov
  * @version $Revision$ $Date$
  */
-public interface Container {
+public interface Container extends Serializable {
 
     /**
      * Returns the contained value.

Modified: commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/Variables.java
URL: http://svn.apache.org/viewvc/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/Variables.java?rev=652925&r1=652924&r2=652925&view=diff
==============================================================================
--- commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/Variables.java (original)
+++ commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/Variables.java Fri May
 2 15:05:41 2008
@@ -16,6 +16,8 @@
  */
 package org.apache.commons.jxpath;
 
+import java.io.Serializable;
+
 /**
  * Variables provide access to a global set of values accessible via XPath.
  * XPath can reference variables using the <code>"$varname"</code> syntax.
@@ -25,7 +27,7 @@
  * @author Dmitri Plotnikov
  * @version $Revision$ $Date$
  */
-public interface Variables {
+public interface Variables extends Serializable {
 
     /**
      * Returns true if the specified variable is declared.

Modified: commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/QName.java
URL: http://svn.apache.org/viewvc/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/QName.java?rev=652925&r1=652924&r2=652925&view=diff
==============================================================================
--- commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/QName.java (original)
+++ commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/QName.java Fri May 
2 15:05:41 2008
@@ -16,6 +16,8 @@
  */
 package org.apache.commons.jxpath.ri;
 
+import java.io.Serializable;
+
 
 /**
  * A qualified name: a combination of an optional namespace prefix
@@ -24,7 +26,9 @@
  * @author Dmitri Plotnikov
  * @version $Revision$ $Date$
  */
-public class QName {
+public class QName implements Serializable {
+    private static final long serialVersionUID = 7616199282015091496L;
+
     private String prefix;
     private String name;
     private String qualifiedName;

Modified: commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/servlet/KeywordVariables.java
URL: http://svn.apache.org/viewvc/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/servlet/KeywordVariables.java?rev=652925&r1=652924&r2=652925&view=diff
==============================================================================
--- commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/servlet/KeywordVariables.java
(original)
+++ commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/servlet/KeywordVariables.java
Fri May  2 15:05:41 2008
@@ -26,6 +26,7 @@
  * @version $Revision$ $Date$
  */
 public class KeywordVariables implements Variables {
+    private static final long serialVersionUID = 894145608741325442L;
 
     private String keyword;
     private Object object;

Modified: commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/xml/DocumentContainer.java
URL: http://svn.apache.org/viewvc/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/xml/DocumentContainer.java?rev=652925&r1=652924&r2=652925&view=diff
==============================================================================
--- commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/xml/DocumentContainer.java
(original)
+++ commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/xml/DocumentContainer.java
Fri May  2 15:05:41 2008
@@ -44,9 +44,7 @@
     /** JDOM constant */
     public static final String MODEL_JDOM = "JDOM";
 
-    private Object document;
-    private URL xmlURL;
-    private String model;
+    private static final long serialVersionUID = -8713290334113427066L;
 
     private static HashMap parserClasses = new HashMap();
     static {
@@ -58,6 +56,10 @@
 
     private static HashMap parsers = new HashMap();
 
+    private Object document;
+    private URL xmlURL;
+    private String model;
+
     /**
      * Add an XML parser.  Parsers for the models "DOM" and "JDOM" are
      * pre-registered.



Mime
View raw message