commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From l..@apache.org
Subject svn commit: r611643 - in /commons/proper/math/trunk: findbugs-exclude-filter.xml pom.xml
Date Sun, 13 Jan 2008 21:00:01 GMT
Author: luc
Date: Sun Jan 13 12:59:58 2008
New Revision: 611643

URL: http://svn.apache.org/viewvc?rev=611643&view=rev
Log:
added an exclusion filter file for findbugs, to prevent false positives from being displayed

Added:
    commons/proper/math/trunk/findbugs-exclude-filter.xml   (with props)
Modified:
    commons/proper/math/trunk/pom.xml

Added: commons/proper/math/trunk/findbugs-exclude-filter.xml
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/findbugs-exclude-filter.xml?rev=611643&view=auto
==============================================================================
--- commons/proper/math/trunk/findbugs-exclude-filter.xml (added)
+++ commons/proper/math/trunk/findbugs-exclude-filter.xml Sun Jan 13 12:59:58 2008
@@ -0,0 +1,80 @@
+<?xml version="1.0"?>
+<!--
+   Licensed to the Apache Software Foundation (ASF) under one or more
+   contributor license agreements.  See the NOTICE file distributed with
+   this work for additional information regarding copyright ownership.
+   The ASF licenses this file to You under the Apache License, Version 2.0
+   (the "License"); you may not use this file except in compliance with
+   the License.  You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific mathuage governing permissions and
+   limitations under the License.
+-->
+
+<!--
+  This file contains some false positive bugs detected by findbugs. Their
+  false positive nature has been analyzed individually and they have been
+  put here to instruct findbugs it must ignore them.
+-->
+<FindBugsFilter>
+
+  <!--  the following equality tests are part of the reference algorithms -->
+  <!--  which already know about limited precision of the double numbers -->
+  <Match>
+    <Class name="org.apache.commons.math.analysis.BrentSolver" />
+    <Method name="solve" params="double,double,double,double,double,double" returns="double"
/>
+    <Bug pattern="FE_FLOATING_POINT_EQUALITY" />
+  </Match>
+  <Match>
+    <Class name="org.apache.commons.math.analysis.MullerSolver" />
+    <Or>
+      <Method name="solve"  params="double,double" returns="double" />
+      <Method name="solve2" params="double,double" returns="double" />
+    </Or>
+    <Bug pattern="FE_FLOATING_POINT_EQUALITY" />
+  </Match>
+
+
+  <!-- The following equality test is intentional and needed for rounding purposes -->
+  <Match>
+    <Class name="org.apache.commons.math.util.MathUtils" />
+    <Method name="roundUnscaled" params="double,double,int" returns="double" />
+    <Bug pattern="FE_FLOATING_POINT_EQUALITY" />
+  </Match>
+
+
+  <!-- the following expositions of internal representation are intentional and documented
-->
+  <Match>
+    <Class name="org.apache.commons.math.linear.BigMatrixImpl"/>
+    <Method name="getDataRef" params="" returns="java.math.BigDecimal[][]" />
+    <Bug pattern="EI_EXPOSE_REP" />
+  </Match>
+  <Match>
+    <Class name="org.apache.commons.math.linear.RealMatrixImpl"/>
+    <Method name="getDataRef" params="" returns="double[][]" />
+    <Bug pattern="EI_EXPOSE_REP" />
+  </Match>
+  <Match>
+    <Class name="org.apache.commons.math.util.ResizableDoubleArray"/>
+    <Method name="getValues" params="" returns="double[]" />
+    <Bug pattern="EI_EXPOSE_REP" />
+  </Match>
+
+  <!-- The following cases are intentional unit tests for null parameters -->
+  <Match>
+    <Class name="org.apache.commons.math.stat.StatUtilsTest" />
+    <Method name="testPercentile" params="" returns="void" />
+    <Bug pattern="NP_NULL_PARAM_DEREF_NONVIRTUAL" />
+  </Match>
+  <Match>
+    <Class name="org.apache.commons.math.analysis.UnivariateRealSolverFactoryImplTest"
/>
+    <Method name="testNewNewtonSolverNull" params="" returns="void" />
+    <Bug pattern="NP_NULL_PARAM_DEREF_ALL_TARGETS_DANGEROUS" />
+  </Match>
+
+</FindBugsFilter>

Propchange: commons/proper/math/trunk/findbugs-exclude-filter.xml
------------------------------------------------------------------------------
    svn:eol-style = native

Modified: commons/proper/math/trunk/pom.xml
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/pom.xml?rev=611643&r1=611642&r2=611643&view=diff
==============================================================================
--- commons/proper/math/trunk/pom.xml (original)
+++ commons/proper/math/trunk/pom.xml Sun Jan 13 12:59:58 2008
@@ -260,6 +260,7 @@
         <configuration>
           <threshold>Normal</threshold>
           <effort>Default</effort>
+          <excludeFilterFile>${basedir}/findbugs-exclude-filter.xml</excludeFilterFile>
        </configuration>
       </plugin>
       <plugin>



Mime
View raw message