commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sgoes...@apache.org
Subject svn commit: r608161 - in /commons/sandbox/exec/trunk/src/main/java/org/apache/commons/exec/launcher: CommandLauncherFactory.java OS2CommandLauncher.java
Date Wed, 02 Jan 2008 17:58:46 GMT
Author: sgoeschl
Date: Wed Jan  2 09:58:37 2008
New Revision: 608161

URL: http://svn.apache.org/viewvc?rev=608161&view=rev
Log:
+) removed comment regarding using Java13CommandLauncher for OS/2

+) added a note to OS2CommandLauncher that it is currently not used

+) unable to test if the code really works for OS/2

Modified:
    commons/sandbox/exec/trunk/src/main/java/org/apache/commons/exec/launcher/CommandLauncherFactory.java
    commons/sandbox/exec/trunk/src/main/java/org/apache/commons/exec/launcher/OS2CommandLauncher.java

Modified: commons/sandbox/exec/trunk/src/main/java/org/apache/commons/exec/launcher/CommandLauncherFactory.java
URL: http://svn.apache.org/viewvc/commons/sandbox/exec/trunk/src/main/java/org/apache/commons/exec/launcher/CommandLauncherFactory.java?rev=608161&r1=608160&r2=608161&view=diff
==============================================================================
--- commons/sandbox/exec/trunk/src/main/java/org/apache/commons/exec/launcher/CommandLauncherFactory.java
(original)
+++ commons/sandbox/exec/trunk/src/main/java/org/apache/commons/exec/launcher/CommandLauncherFactory.java
Wed Jan  2 09:58:37 2008
@@ -26,11 +26,12 @@
 public final class CommandLauncherFactory {
 
     private CommandLauncherFactory() {
-
     }
 
     /**
-     * 
+     * Factory method to create an appropriate launcher.
+     *
+     * @return the command launcher
      */
     public static CommandLauncher createVMLauncher() {
         // Try using a JDK 1.3 launcher
@@ -38,8 +39,6 @@
 
         if (OS.isFamilyOpenVms()) {
             launcher = new VmsCommandLauncher();
-            // TODO why not use Java13CommandLauncher on OS2?
-            //} else if (!OS.isFamilyOS2()) {
         } else {
             launcher = new Java13CommandLauncher();
         }

Modified: commons/sandbox/exec/trunk/src/main/java/org/apache/commons/exec/launcher/OS2CommandLauncher.java
URL: http://svn.apache.org/viewvc/commons/sandbox/exec/trunk/src/main/java/org/apache/commons/exec/launcher/OS2CommandLauncher.java?rev=608161&r1=608160&r2=608161&view=diff
==============================================================================
--- commons/sandbox/exec/trunk/src/main/java/org/apache/commons/exec/launcher/OS2CommandLauncher.java
(original)
+++ commons/sandbox/exec/trunk/src/main/java/org/apache/commons/exec/launcher/OS2CommandLauncher.java
Wed Jan  2 09:58:37 2008
@@ -31,6 +31,8 @@
  * Unlike Windows NT and friends, OS/2's cd doesn't support the /d switch to
  * change drives and directories in one go.
  * </p>
+ * Please not that this class is currently unused because the Java13CommandLauncher
+ * is used for 0S/2
  */
 public class OS2CommandLauncher extends CommandLauncherProxy {
 



Mime
View raw message