From commits-return-558-apmail-commons-commits-archive=commons.apache.org@commons.apache.org Sat Oct 13 11:58:50 2007 Return-Path: Delivered-To: apmail-commons-commits-archive@locus.apache.org Received: (qmail 53823 invoked from network); 13 Oct 2007 11:58:49 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 13 Oct 2007 11:58:49 -0000 Received: (qmail 8609 invoked by uid 500); 13 Oct 2007 11:58:36 -0000 Delivered-To: apmail-commons-commits-archive@commons.apache.org Received: (qmail 8523 invoked by uid 500); 13 Oct 2007 11:58:36 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 8514 invoked by uid 99); 13 Oct 2007 11:58:36 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 13 Oct 2007 04:58:36 -0700 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO eris.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 13 Oct 2007 11:58:47 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 6741F1A9832; Sat, 13 Oct 2007 04:57:57 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r584391 - /commons/proper/proxy/trunk/src/test/java/org/apache/commons/proxy/provider/remoting/TestRmiProvider.java Date: Sat, 13 Oct 2007 11:57:57 -0000 To: commits@commons.apache.org From: jcarman@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20071013115757.6741F1A9832@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: jcarman Date: Sat Oct 13 04:57:56 2007 New Revision: 584391 URL: http://svn.apache.org/viewvc?rev=584391&view=rev Log: PROXY-3: RMI Test Case Failures on Linux Modified: commons/proper/proxy/trunk/src/test/java/org/apache/commons/proxy/provider/remoting/TestRmiProvider.java Modified: commons/proper/proxy/trunk/src/test/java/org/apache/commons/proxy/provider/remoting/TestRmiProvider.java URL: http://svn.apache.org/viewvc/commons/proper/proxy/trunk/src/test/java/org/apache/commons/proxy/provider/remoting/TestRmiProvider.java?rev=584391&r1=584390&r2=584391&view=diff ============================================================================== --- commons/proper/proxy/trunk/src/test/java/org/apache/commons/proxy/provider/remoting/TestRmiProvider.java (original) +++ commons/proper/proxy/trunk/src/test/java/org/apache/commons/proxy/provider/remoting/TestRmiProvider.java Sat Oct 13 04:57:56 2007 @@ -21,7 +21,6 @@ import org.apache.commons.proxy.exception.ObjectProviderException; import org.apache.commons.proxy.util.rmi.RmiEcho; import org.apache.commons.proxy.util.rmi.RmiEchoImpl; -import org.apache.commons.proxy.provider.remoting.RmiProvider; import java.rmi.NotBoundException; import java.rmi.RemoteException; @@ -38,8 +37,8 @@ private RmiEchoImpl implObject; private Registry registry; - // A port that is unlikely to clash with another on the build machine - private int UNLIKELY_PORT = 13099; + private int port = 65535; // Last "dynamic" port (decremented for each test). + private static final String SERVICE_NAME = "echo"; //---------------------------------------------------------------------------------------------------------------------- // Other Methods @@ -47,14 +46,15 @@ public void setUpRegistry() throws Exception { - implObject = new RmiEchoImpl( UNLIKELY_PORT ); - registry = LocateRegistry.createRegistry( UNLIKELY_PORT ); - registry.bind( "echo", implObject ); + implObject = new RmiEchoImpl( port ); + registry = LocateRegistry.createRegistry( port ); + registry.bind( SERVICE_NAME, implObject ); + } public void tearDown() throws Exception { - if( registry != null ) + if ( registry != null ) { tearDownRegistry(); } @@ -63,32 +63,33 @@ public void testWithNoRegistry() throws Exception { final RmiProvider provider = new RmiProvider(); - provider.setName( "echo" ); - provider.setPort( UNLIKELY_PORT ); + provider.setName( SERVICE_NAME ); + provider.setPort( port ); try { provider.getObject(); fail(); } - catch( ObjectProviderException e ) + catch ( ObjectProviderException e ) { } } - + private void tearDownRegistry() throws RemoteException, NotBoundException { - registry.unbind( "echo" ); + registry.unbind( SERVICE_NAME ); UnicastRemoteObject.unexportObject( implObject, true ); UnicastRemoteObject.unexportObject( registry, true ); registry = null; + port--; } public void testGetObject() throws Exception { setUpRegistry(); - final RmiProvider provider = new RmiProvider( "echo" ); - provider.setPort( UNLIKELY_PORT ); + final RmiProvider provider = new RmiProvider( SERVICE_NAME ); + provider.setPort( port ); final RmiEcho echo = ( RmiEcho ) provider.getObject(); assertEquals( "Hello, World!", echo.echoBack( "Hello, World!" ) ); } @@ -96,8 +97,8 @@ public void testGetObjectWithHost() throws Exception { setUpRegistry(); - final RmiProvider provider = new RmiProvider( "localhost", "echo" ); - provider.setPort( UNLIKELY_PORT ); + final RmiProvider provider = new RmiProvider( "localhost", SERVICE_NAME ); + provider.setPort( port ); final RmiEcho echo = ( RmiEcho ) provider.getObject(); assertEquals( "Hello, World!", echo.echoBack( "Hello, World!" ) ); } @@ -106,13 +107,13 @@ { setUpRegistry(); final RmiProvider provider = new RmiProvider( "bogus" ); - provider.setPort( UNLIKELY_PORT ); + provider.setPort( port ); try { provider.getObject(); fail(); } - catch( ObjectProviderException e ) + catch ( ObjectProviderException e ) { } } @@ -120,8 +121,8 @@ public void testGetObjectWithPortAndHost() throws Exception { setUpRegistry(); - final RmiProvider provider = new RmiProvider( "localhost", Registry.REGISTRY_PORT, "echo" ); - provider.setPort( UNLIKELY_PORT ); + final RmiProvider provider = new RmiProvider( "localhost", Registry.REGISTRY_PORT, SERVICE_NAME ); + provider.setPort( port ); final RmiEcho echo = ( RmiEcho ) provider.getObject(); assertEquals( "Hello, World!", echo.echoBack( "Hello, World!" ) ); } @@ -129,11 +130,10 @@ public void testGetObjectWithPortAndHostAndFactory() throws Exception { setUpRegistry(); - final RmiProvider provider = new RmiProvider( "localhost", UNLIKELY_PORT, - RMISocketFactory.getDefaultSocketFactory(), "echo" ); + final RmiProvider provider = new RmiProvider( "localhost", port, + RMISocketFactory.getDefaultSocketFactory(), SERVICE_NAME ); final RmiEcho echo = ( RmiEcho ) provider.getObject(); assertEquals( "Hello, World!", echo.echoBack( "Hello, World!" ) ); } - }