Mailing-List: contact users-help@cocoon.apache.org; run by ezmlm
Precedence: bulk
Reply-To: users@cocoon.apache.org
Received-SPF: pass (athena.apache.org: domain of joerg.heinicke@gmx.de
 designates 213.165.64.20 as permitted sender)
Message-ID: <487CF381.3070102@gmx.de>
Date: Tue, 15 Jul 2008 20:59:13 +0200
From: Joerg Heinicke <joerg.heinicke@gmx.de>
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US;
 rv:1.8.1.15) Gecko/20080621 SeaMonkey/1.1.10
MIME-Version: 1.0
To: users@cocoon.apache.org
Subject: Re: Is it possible to restrict file uploads to certain URLs?
References: <efe2a0400801281620i54031f8t1c0bd4db1e3a8833@mail.gmail.com>
In-Reply-To: <efe2a0400801281620i54031f8t1c0bd4db1e3a8833@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

On 29.01.2008 01:20, Andy Stevens wrote:

> I have a new requirement for one of our sites to allow the users to
> upload some files.  However, I read in the Cocoon docs/wiki that
> switching on the enable-uploads init parameter will make it use the
> multipart request factory etc. on all requests it receives.  This
> seems to me like a lot of unnecessary work (and either disk IO or heap
> churn) when only a couple of pipelines will be processing the uploaded
> files.

If you look at the actual implementation you will see that there isn't a 
real overhead:

CocoonServlet.service(..):

   if (this.enableUploads) {
       request = requestFactory.getServletRequest(req);
   } else {
       request = req;
   }

That's exactly what you described, as soon as uploads are enabled 
multipart request factory is used.

RequestFactory.getServletRequest(..):

   String contentType = request.getContentType();

   if ((contentType != null) &&
       (contentType.toLowerCase().indexOf("multipart/form-data") > -1)) {

       // wrap request object in MultipartHttpServletRequest
   }

   return request;

This means the actual multipart parsing is triggered only by form 
content type "multipart/form-data" - and that's what you have to set 
explicitly on the form. So the overhead is only to check for that 
particular request property.

Joerg


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@cocoon.apache.org
For additional commands, e-mail: users-help@cocoon.apache.org