cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alfred Nathaniel (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (COCOON-2360) [2,2] Inconsistent method names
Date Thu, 21 Feb 2019 19:28:00 GMT

     [ https://issues.apache.org/jira/browse/COCOON-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Alfred Nathaniel updated COCOON-2360:
-------------------------------------
    Affects Version/s: 2.2
              Summary: [2,2] Inconsistent method names  (was: Inconsistent method names)

> [2,2] Inconsistent method names
> -------------------------------
>
>                 Key: COCOON-2360
>                 URL: https://issues.apache.org/jira/browse/COCOON-2360
>             Project: Cocoon
>          Issue Type: Improvement
>          Components: Blocks: (Undefined)
>    Affects Versions: 2.2
>            Reporter: KuiLIU
>            Priority: Major
>
> The following method is named as "select".
> "select" is prone to mean that something will be selected.
> But this method actually checks whether the expression is contained or not.
> So, rename it as "contains" should be more clearly and intuitively.
>     public boolean select( String expression ) {
>         return this.set.contains( expression );
>     }



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message