Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cocoon.apache.org
Date: Mon, 17 Oct 2016 12:45:58 +0000 (UTC)
From: "Ben Fortuna (JIRA)" <jira@apache.org>
To: dev@cocoon.apache.org
Message-ID: <JIRA.12998394.1471583201000.3787.1476708358857@Atlassian.JIRA>
In-Reply-To: <JIRA.12998394.1471583201000@Atlassian.JIRA>
References: <JIRA.12998394.1471583201000@Atlassian.JIRA> <JIRA.12998394.1471583201219@arcas>
Subject: [jira] [Comment Edited] (COCOON-2352) XMLEncoder doesn't support
 Unicode surrogate pairs
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Mon, 17 Oct 2016 12:46:02 -0000


    [ https://issues.apache.org/jira/browse/COCOON-2352?page=3Dcom.atlassia=
n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D155=
82147#comment-15582147 ]=20

Ben Fortuna edited comment on COCOON-2352 at 10/17/16 12:45 PM:
----------------------------------------------------------------

Hmm, do you have a link to the source? I checked on BRANCH_2_1_X and it sti=
ll has the old code. I noticed the error is on line 42, but the test I subm=
itted only has 33 lines.=20

Note it is important for the test to encode the surrogate pairs together, w=
hich is why I had the sequence like this:

```
char[] expectedValue =3D encoder.encode((char) 127808);
// surrogate 1/2
assertTrue(encoder.encode('\uD83C').length =3D=3D 0);
// surrogate 2/2
assertTrue(Arrays.equals(expectedValue, encoder.encode('\uDF40')));
```


was (Author: fortuna):
Hmm, do you have a link to the source? I checked on BRANCH_2_1_X and it sti=
ll has the old code. I noticed the error is on line 42, but the test I subm=
itted only has 33 lines.=20

Note it is important for the test to encode the surrogate pairs together, w=
hich is why I had the sequence like this:

{code}
char[] expectedValue =3D encoder.encode((char) 127808);
// surrogate 1/2
assertTrue(encoder.encode('\uD83C').length =3D=3D 0);
// surrogate 2/2
assertTrue(Arrays.equals(expectedValue, encoder.encode('\uDF40')));
{code}


> XMLEncoder doesn't support Unicode surrogate pairs
> --------------------------------------------------
>
>                 Key: COCOON-2352
>                 URL: https://issues.apache.org/jira/browse/COCOON-2352
>             Project: Cocoon
>          Issue Type: Bug
>          Components: * Cocoon Core, Blocks: Serializers
>    Affects Versions: 2.1.12
>            Reporter: Ben Fortuna
>            Assignee: Francesco Chicchiricc=C3=B2
>             Fix For: 2.1.13
>
>
> Whilst investigating an issue with the Sling project and support for emoj=
i characters, I've come to notice that the XMLEncoder used by HTMLSerialize=
r doesn't support Unicode surrogate pairs to represent higher order unicode=
 characters.
> A simple unit test that demonstrates this issue is here:
> https://github.com/micronode/whistlepost/blob/master/whistlepost-rewrite-=
lib/src/test/groovy/org/apache/cocoon/components/serializers/encoding/XMLEn=
coderTest.groovy
> More background info here also: SLING-5973
> This seems to have been identified/addressed in other Apache projects als=
o:
> https://issues.apache.org/jira/browse/THRIFT-3403?jql=3Dtext%20~%20%22sur=
rogate%20pairs%22


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)