cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Francesco Chicchiriccò (JIRA) <j...@apache.org>
Subject [jira] [Commented] (COCOON-2352) XMLEncoder doesn't support Unicode surrogate pairs
Date Fri, 14 Oct 2016 06:48:20 GMT

    [ https://issues.apache.org/jira/browse/COCOON-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15574444#comment-15574444
] 

Francesco Chicchiriccò commented on COCOON-2352:
------------------------------------------------

Ben, I have applied your further PR in [1] but I have unfortunately noticed later that the
test is failing in this assertion:

assertTrue(Arrays.equals(expectedValue, encoder.encode('\uDF40')));

Unfortunately, I have noticed this *after* committing to COCOON_2_1_X, but I have stopped
myself right before deploying the updated SNAPSHOT artifact (thanks Maven and the surefire
plugin!).

Does your test case need to be updated as well?

[1] http://svn.apache.org/viewvc?rev=1764819&view=rev

> XMLEncoder doesn't support Unicode surrogate pairs
> --------------------------------------------------
>
>                 Key: COCOON-2352
>                 URL: https://issues.apache.org/jira/browse/COCOON-2352
>             Project: Cocoon
>          Issue Type: Bug
>          Components: * Cocoon Core, Blocks: Serializers
>    Affects Versions: 2.1.12
>            Reporter: Ben Fortuna
>            Assignee: Francesco Chicchiriccò
>             Fix For: 2.1.13
>
>
> Whilst investigating an issue with the Sling project and support for emoji characters,
I've come to notice that the XMLEncoder used by HTMLSerializer doesn't support Unicode surrogate
pairs to represent higher order unicode characters.
> A simple unit test that demonstrates this issue is here:
> https://github.com/micronode/whistlepost/blob/master/whistlepost-rewrite-lib/src/test/groovy/org/apache/cocoon/components/serializers/encoding/XMLEncoderTest.groovy
> More background info here also: SLING-5973
> This seems to have been identified/addressed in other Apache projects also:
> https://issues.apache.org/jira/browse/THRIFT-3403?jql=text%20~%20%22surrogate%20pairs%22



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message