cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Francesco Chicchiriccò <ilgro...@apache.org>
Subject Re: cocoon 2.1.x and java 8
Date Sat, 31 Jan 2015 05:24:03 GMT
On 30/01/2015 15:09, Carlos Chávez wrote:
> Hi Francesco.
>
> I uploaded the patch.

Hi Carlo,
patch applied (and issue closed), thanks.

Regards.

> On 16/01/15 01:24, Francesco Chicchiriccò wrote:
>> On 15/01/2015 18:59, Carlos Chávez wrote:
>>> Hi Francesco.
>>>
>>> I downloaded that file and it works with java 8.
>>>
>>> I found another test that is failing,
>>> http://localhost:8888/samples/blocks/xsp/java/java5, this seems to be
>>> related to :
>>>
>>> "// Set the sourceCodeVersion"
>>> "// Set the target platform"
>>>
>>> Check the patch:
>> Hi,
>> thanks for reporting: could you please unify my patch with your changes
>> and attach the resulting patch to
>>
>> https://issues.apache.org/jira/browse/COCOON-2344
>>
>> ? Thanks.
>>
>> Regards.
>>
>>> Index:
>>> src/blocks/xsp/java/org/apache/cocoon/components/language/programming/java/EclipseJavaCompiler.java
>>>
>>> ===================================================================
>>> ---
>>> workspace/cocoon-BRANCH_2_1_X/src/blocks/xsp/java/org/apache/cocoon/components/language/programming/java/EclipseJavaCompiler.java
>>>
>>> (revision 1652165)
>>> +++
>>> workspace/cocoon-BRANCH_2_1_X/src/blocks/xsp/java/org/apache/cocoon/components/language/programming/java/EclipseJavaCompiler.java
>>>
>>> (working copy)
>>> @@ -215,8 +215,11 @@
>>>                    }
>>>                    return result;
>>>                }
>>> -        }
>>>
>>> +            public boolean ignoreOptionalProblems() {
>>> +                return false;
>>> +            }
>>> +        }
>>>
>>>            final INameEnvironment env = new INameEnvironment() {
>>>
>>> @@ -336,6 +339,18 @@
>>>            }
>>>            // Set the sourceCodeVersion
>>>            switch (this.compilerComplianceLevel) {
>>> +            case 180:
>>> +                settings.put(CompilerOptions.OPTION_Source,
>>> CompilerOptions.VERSION_1_8);
>>> +                settings.put(CompilerOptions.OPTION_Compliance,
>>> CompilerOptions.VERSION_1_8);
>>> +                break;
>>> +            case 170:
>>> +                settings.put(CompilerOptions.OPTION_Source,
>>> CompilerOptions.VERSION_1_7);
>>> +                settings.put(CompilerOptions.OPTION_Compliance,
>>> CompilerOptions.VERSION_1_7);
>>> +                break;
>>> +            case 160:
>>> +                settings.put(CompilerOptions.OPTION_Source,
>>> CompilerOptions.VERSION_1_6);
>>> +                settings.put(CompilerOptions.OPTION_Compliance,
>>> CompilerOptions.VERSION_1_6);
>>> +                break;
>>>                case 150:
>>>                    settings.put(CompilerOptions.OPTION_Source,
>>> CompilerOptions.VERSION_1_5);
>>>                    settings.put(CompilerOptions.OPTION_Compliance,
>>> CompilerOptions.VERSION_1_5);
>>> @@ -348,6 +363,15 @@
>>>            }
>>>            // Set the target platform
>>>            switch (SystemUtils.JAVA_VERSION_INT) {
>>> +            case 180:
>>> +                settings.put(CompilerOptions.OPTION_TargetPlatform,
>>> CompilerOptions.VERSION_1_8);
>>> +                break;
>>> +            case 170:
>>> +                settings.put(CompilerOptions.OPTION_TargetPlatform,
>>> CompilerOptions.VERSION_1_7);
>>> +                break;
>>> +            case 160:
>>> +                settings.put(CompilerOptions.OPTION_TargetPlatform,
>>> CompilerOptions.VERSION_1_6);
>>> +                break;
>>>                case 150:
>>>                    settings.put(CompilerOptions.OPTION_TargetPlatform,
>>> CompilerOptions.VERSION_1_5);
>>>                    break;
>>>
>>>
>>> On 15/01/15 02:19, Francesco Chicchiriccò wrote:
>>>> On 08/01/2015 00:12, Carlos Chávez wrote:
>>>>> Hi all.
>>>>>
>>>>> I'm trying to run cocoon in java 8, I found an issue with the JDT core
>>>>> that did not recognize java 8, the version in cocoon is
>>>>>
>>>>> lib/core/jdtcore-3.1.0.jar
>>>>>
>>>>>
>>>>> I did tried updating that version, what I did was copy the file
>>>>> org.eclipse.jdt.core_3.10.0.v20140902-0626.jar from my Eclipse Luna
>>>>> Installation and it works.
>>>>>
>>>>> I did not find a public repository to download the jtdcore jar, I
>>>>> searched in maven repos and did not find any updated jar.
>>>>>
>>>>> When I compile and run cocoon with java 8, i found the issue testing
>>>>> the
>>>>> sample http://localhost:8888/samples/blocks/xsp/java/cacheable which
it
>>>>> throw a NullPointerException when it tried to compile the XPS.
>>>>>
>>>>> With that version the exception is gone and the page is generated.
>>>>>
>>>>> thoughts, please ?
>>>> Hi Carlos,
>>>> I tried as you explain above and got exactly the same results: only
>>>> found this updated JAR [1], but the error is the same.
>>>>
>>>> However, I have found these places [2] [3] from which the version
>>>> reported above can be downloaded.
>>>> I have opened COCOON-2344 [4] and provided a patch with which the XSP
>>>> sample above is working (checked  with OpenJDK 6 / 7 / 8).
>>>> I have not committed the fix because I have no mean to check if
>>>> everything is working with Java 4 / 5 and also if other XSP features are
>>>> affected.
>>>>
>>>> Can anyone please double check and confirm if the proposed patch can be
>>>> committed?
>>>>
>>>> Regards.
>>>>
>>>> [1]
>>>> http://central.maven.org/maven2/eclipse/jdtcore/3.2.0.v_658/jdtcore-3.2.0.v_658.jar
>>>>
>>>>
>>>> [2]
>>>> http://repository.grepcode.com/java/eclipse.org/4.4.1/plugins/org.eclipse.jdt.core_3.10.0.v20140902-0626.jar
>>>>
>>>>
>>>> [3]
>>>> http://www.aadl.info/aadl/osate/testing/update-site/plugins/org.eclipse.jdt.core_3.10.0.v20140902-0626.jar
>>>>
>>>>
>>>> [4] https://issues.apache.org/jira/browse/COCOON-2344

Mime
View raw message