cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Francesco Chicchiriccò (JIRA) <j...@apache.org>
Subject [jira] [Commented] (COCOON3-102) The org.apache.cocoon.sax.component.XIncludeTransformer is not cacheable
Date Thu, 21 Jun 2012 10:46:42 GMT

    [ https://issues.apache.org/jira/browse/COCOON3-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398337#comment-13398337
] 

Francesco Chicchiriccò commented on COCOON3-102:
------------------------------------------------

Ok, I had a closer look to your patches in COCOON3-100.

Basically - correct me if I'm wrong - we are talking about two different things here:

 1. CachedCacheKey as way to solve the problem I describe above re-opening this issue: you
are using a separate, local, Cache object for making the main Cache object able to recognize
that there is an existing CacheKey during subsequent lookups for IncludeTransformer - this
could apply without modifications to XIncludeTransformer as well.
CachedCacheKey could even use a simple singleton Map for this job - not necessarily SimpleCache,
isn't it?

 2. a better handling for lastModified (and ETag) stuff that would involve SourceValidity
migration from C2.X
This will involve changing a lot of things as you say: how do you see URLUtils.getLastModified()
in this respect? I've recently changed all caching components dealing with URLs to use this
method.

Anyway, I'd like to make C3 caching mechanism as strong as possible, so I'd be happy to help
you (and Thorsten) in this process.
                
> The org.apache.cocoon.sax.component.XIncludeTransformer is not cacheable
> ------------------------------------------------------------------------
>
>                 Key: COCOON3-102
>                 URL: https://issues.apache.org/jira/browse/COCOON3-102
>             Project: Cocoon 3
>          Issue Type: Improvement
>          Components: cocoon-sax
>    Affects Versions: 3.0.0-alpha-3
>            Reporter: Simone Tripodi
>            Assignee: Francesco Chicchiriccò
>             Fix For: 3.0.0-beta-1
>
>         Attachments: COCOON3-102.patch
>
>
> The org.apache.cocoon.sax.component.XIncludeTransformer is not a cacheable pipeline component,
it would be great to implement it as cacheable

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message