Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cocoon.apache.org
Date: Mon, 2 Apr 2012 23:29:21 +0000 (UTC)
From: "Javier Puerto (Commented) (JIRA)" <jira@apache.org>
To: dev@cocoon.apache.org
Message-ID: 
 <2071459802.3862.1333409361324.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <677789507.685.1333190426655.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (COCOON3-95) Sitemap file not validated against
 schema
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/COCOON3-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244826#comment-13244826 ] 

Javier Puerto commented on COCOON3-95:
--------------------------------------

Samples block sitemap file doesn't validate against the schema.
                
> Sitemap file not validated against schema
> -----------------------------------------
>
>                 Key: COCOON3-95
>                 URL: https://issues.apache.org/jira/browse/COCOON3-95
>             Project: Cocoon 3
>          Issue Type: Bug
>          Components: cocoon-general
>    Affects Versions: 3.0.0-beta-1
>            Reporter: Javier Puerto
>         Attachments: SitemapBuilder-COCOON-95.diff, sitemap-validation.tar.gz
>
>
> http://cocoon.markmail.org/thread/cq6nrzy5xladcuys
> Summary: Lars Huttar found that his sitemap declaration was not working as expected. Some matchers worked an others not. Finally the problem was a matcher tag not inside a pipeline tag.
> Attached is a block to reproduce the problem, I just review the SitemapBuilder class and there's not validation at all against a schema. So if the sitemap.xmap file is a XML well formed, C3 will not throw any error about. The ugly issue is that C3 is returning a HTTP status code of 200 instead of a code 500 and also the exception in the log is not very helpful, NullPointerException.
> I think that we should validate the sitemap file or at least response with the right HTTP status code and better error information in this case. We can do something like we have already for the SchemaProcessorTransformer, using the caching to avoid unnecessary processing. The schema file path is trunk/cocoon-sitemap/src/main/resources/cocoon-sitemap-1.0.xsd.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira