cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COCOON3-95) Sitemap file not validated against schema
Date Tue, 03 Apr 2012 10:32:23 GMT

    [ https://issues.apache.org/jira/browse/COCOON3-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245111#comment-13245111
] 

Hudson commented on COCOON3-95:
-------------------------------

Integrated in Cocoon-trunk #164 (See [https://builds.apache.org/job/Cocoon-trunk/164/])
    [COCOON3-95] Applying and reworking a bit provided patch in order to handle sitemap XML
validation when controller: and servlet: namespaces are also present; cocoon-sitemap-1.0.xsd
further extended in order to deal with existing sitemap files (Revision 1308780)

     Result = SUCCESS
ilgrosso : http://svn.apache.org/viewvc/?view=rev&rev=1308780
Files : 
* /cocoon/cocoon3/trunk/cocoon-sample/src/main/resources/COB-INF/sitemap.xmap
* /cocoon/cocoon3/trunk/cocoon-sitemap/src/main/java/org/apache/cocoon/sitemap/SitemapBuilder.java
* /cocoon/cocoon3/trunk/cocoon-sitemap/src/main/resources/cocoon-sitemap-1.0.xsd

                
> Sitemap file not validated against schema
> -----------------------------------------
>
>                 Key: COCOON3-95
>                 URL: https://issues.apache.org/jira/browse/COCOON3-95
>             Project: Cocoon 3
>          Issue Type: Bug
>          Components: cocoon-general
>    Affects Versions: 3.0.0-beta-1
>            Reporter: Javier Puerto
>            Assignee: Francesco Chicchiriccò
>             Fix For: 3.0.0-beta-1
>
>         Attachments: SitemapBuilder-COCOON-95.diff, sitemap-schema.diff, sitemap-validation.tar.gz
>
>
> http://cocoon.markmail.org/thread/cq6nrzy5xladcuys
> Summary: Lars Huttar found that his sitemap declaration was not working as expected.
Some matchers worked an others not. Finally the problem was a matcher tag not inside a pipeline
tag.
> Attached is a block to reproduce the problem, I just review the SitemapBuilder class
and there's not validation at all against a schema. So if the sitemap.xmap file is a XML well
formed, C3 will not throw any error about. The ugly issue is that C3 is returning a HTTP status
code of 200 instead of a code 500 and also the exception in the log is not very helpful, NullPointerException.
> I think that we should validate the sitemap file or at least response with the right
HTTP status code and better error information in this case. We can do something like we have
already for the SchemaProcessorTransformer, using the caching to avoid unnecessary processing.
The schema file path is trunk/cocoon-sitemap/src/main/resources/cocoon-sitemap-1.0.xsd.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message