Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cocoon.apache.org
Received-SPF: pass (nike.apache.org: domain of simone.tripodi@gmail.com
 designates 209.85.220.179 as permitted sender)
MIME-Version: 1.0
Sender: simone.tripodi@gmail.com
In-Reply-To: <A98F6459E618D84E8D2D430C4F26D9B60BC4084BF9@LPZHWMEXE11.base.dom>
References: 
 <CAAqLGLPB5vbPUjK7Hfp++6OOygRH6n4-iEgD4rvbEs89OXFC1w@mail.gmail.com>
	<78B923726E7D59429936580CF127E943A1F35896CD@eu1rdcrdc1wx032.exi.nxp.com>
	<CAAqLGLMqO-WzADxv5zava1+5qZdREkzdv49jErHvL9ccYBUMnQ@mail.gmail.com>
	<78B923726E7D59429936580CF127E943A1F35897E9@eu1rdcrdc1wx032.exi.nxp.com>
	<CAAqLGLNUkTRnFvtr4jOXoryKk99iUwc3XP0mh3nOwVTsqJp4DQ@mail.gmail.com>
	<A98F6459E618D84E8D2D430C4F26D9B60BC4084BF9@LPZHWMEXE11.base.dom>
Date: Fri, 16 Dec 2011 16:06:19 +0100
Message-ID: 
 <CAAqLGLPWz1BKrWUX-KU6nsAuPfBz3nReS54RDwW6d3vdgNH4Kg@mail.gmail.com>
Subject: Re: [C3] new pipeline component: variabelExpander
From: Simone Tripodi <simonetripodi@apache.org>
To: dev@cocoon.apache.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi Nathaniel!

*terrific* feedback, you already put me in the condition I'm going to
modify the transformer adoption your suggestion!
Clear, simple, linear - priceless!
I'll let you know when terminated!
-Simo

http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/


On Fri, Dec 16, 2011 at 1:38 PM, Nathaniel, Alfred
<Alfred.Nathaniel@six-group.com> wrote:
> Hi Simone,
>
> Why this special API call to add it to the pipeline?
>
> I think is should be a regular transformer you can add any number of time=
 wherever you need it:
>
> =C2=A0 =C2=A0 =C2=A0 =C2=A0VariableExpander expander =3D new VariableExpa=
nder();
> =C2=A0 =C2=A0 =C2=A0 =C2=A0expander.addProperty( "build.base", "/Users/co=
coon" );
> =C2=A0 =C2=A0 =C2=A0 =C2=A0expander.addProperty( "build.home", "${build.b=
ase}/workspace" );
> =C2=A0 =C2=A0 =C2=A0 =C2=A0expander.addProperty( "dist.home", "${build.ba=
se}/downloads" );
> =C2=A0 =C2=A0 =C2=A0 =C2=A0expander.addProperty( "text.property", "Cocoon=
3 rocks!" );
>
> then creating and run their pipeline adding the VariableExpander:
>
> =C2=A0 =C2=A0 =C2=A0 =C2=A0newNonCachingPipeline().setURLGenerator(
> getClass().getResource( "/variables-expander.xml" ) )
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 .addTransformer( expander )
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 .addSerializer()
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 .withEmptyConfiguration()
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 .setup( System.out )
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 .execute();
>
> That makes it also easier to add configuration to the expander, for examp=
le:
>
> * use other marker than ${}, in case you may want generate generate a fil=
e using that syntax for its own purposes
> * what to do if there if the property name is undefined: replace it by no=
thing / leave as is / throw exception
>
> Also by not just using a stupid property map, it is much easier to avoid =
infinite recursions such as setProperty("build.home","${build.home}/workspa=
ce").
>
> Cheers, Alfred.
>
> -----Original Message-----
> From: simone.tripodi@gmail.com [mailto:simone.tripodi@gmail.com] On Behal=
f Of Simone Tripodi
> Sent: Donnerstag, 15. Dezember 2011 18:02
> To: dev@cocoon.apache.org
> Subject: Re: [C3] new pipeline component: variabelExpander
>
> Hi Robby :)
>
> On Thu, Dec 15, 2011 at 5:56 PM, Robby Pelssers <Robby.Pelssers@nxp.com> =
wrote:
>> Would it be justified to say that it acts as some kind of transformer (a=
lthough non-xslt based) in this case which replaces all variable references=
 with the value from the Map or Properties provided?
>
> exactly, it just replaces plain text inside attributes/body elements :P
>
>>=C2=A0And I suppose it works on any text, not just XML?!
>>
>
> Not ATM, it works as XmlTransformer :(
>
>> Bring it on ;-)
>>
>
> I'll do, thanks! :)
> best;
> -Simo
>
> http://people.apache.org/~simonetripodi/
> http://simonetripodi.livejournal.com/
> http://twitter.com/simonetripodi
> http://www.99soft.org/
>
> The content of this e-mail is intended only for the confidential use of t=
he person addressed.
> If you are not the intended recipient, please notify the sender and delet=
e this e-mail immediately.
> Thank you.