Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cocoon.apache.org
Received-SPF: neutral (athena.apache.org: local policy)
Message-ID: <4E3BF8D1.6050704@apache.org>
Date: Fri, 05 Aug 2011 16:06:09 +0200
From: =?ISO-8859-1?Q?Francesco_Chicchiricc=F2?= <ilgrosso@apache.org>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US;
 rv:1.9.2.18) Gecko/20110617 Lightning/1.0b2 Thunderbird/3.1.11
MIME-Version: 1.0
To: dev@cocoon.apache.org
Subject: Re: Filtering out (some) Sonar violations
References: <4E3B92A4.5000909@apache.org>
 <A98F6459E618D84E8D2D430C4F26D9B60ACB40523C@LPZHWMEXE11.base.dom>
 <4E3BBE87.1050102@indoqa.com>
In-Reply-To: <4E3BBE87.1050102@indoqa.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit

Hi folks,
short time after asking [1], people at infrastructure made a custom 
ruleset for Cocoon at Sonar [2] and we have no more Blocker or Critical 
violations.

Kudos to the infrastructure team!

[1] https://issues.apache.org/jira/browse/INFRA-3828
[2] https://analysis.apache.org/rules_configuration/index/10

On 05/08/2011 11:57, Steven Dolg wrote:
> Am 05.08.2011 11:25, schrieb Nathaniel, Alfred:
>> Hi Francesco,
>>
>> I am a big fan of Findbugs and persueing a zero-warnings policy.
>> In other projects we use a Findbugs exclude filter file to
>> disable warnings and document the deliberation for doing so.
>
> That's what we do as well.
> TBH, the default ruleset contains more than one rule that I find 
> highly suspicious if not outright stupid.
> Zero warnings is IMO the only way to go, same as with unit tests.
>
>>
>> Sonar should foresee to pull such an exclude filter from the
>> project's code base.
>>
>> NB we also exclude XFB_XML_FACTORY_BYPASS with reason
>> "axis.client.Stub requires specific axis.message.SOAPHeaderElement".
>
> Maybe we should try to get our own set of rules (there are rulesets 
> "CXF Rules with Findbugs" and "My Faces with Findbugs", so I guess 
> that's possible).
>
> I think it's easier to start with a more lenient ruleset, work (close) 
> to 0 warnings and then add a couple more restrictions and repeat.
> Sitting in front of hundreds of warnings can be a frustrating 
> situation...
>
> Steven
>
>>
>> Cheers, Alfred.
>>
>> -----Original Message-----
>> From: Francesco Chicchiricc� [mailto:ilgrosso@apache.org]
>> Sent: Freitag, 5. August 2011 08:50
>> To: dev@cocoon.apache.org
>> Subject: Filtering out (some) Sonar violations
>>
>> ...
>>
>> My proposal would be to open a issue to INFRA in order to ask for
>> disabling these two rules: do you see any problem, with this?
>>
>> For my personal experience about Findbugs, PMD and Checkstyle, it is
>> rather impossible to satisfy all the rules (thus bringing the number of
>> violations to zero); however, I personally think that reducing the huge
>> amount that we have at the moment would dramatically improve Cocoon 3's
>> source code quality.
>>
>> ...
>>
>> The content of this e-mail is intended only for the confidential use 
>> of the person addressed.
>> If you are not the intended recipient, please notify the sender and 
>> delete this e-mail immediately.
>> Thank you.
-- 
Francesco Chicchiricc�

Apache Cocoon Committer and PMC Member
http://people.apache.org/~ilgrosso/