cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Francesco Chicchiriccò <ilgro...@apache.org>
Subject Re: [C3] *LinkRewriterTransformer
Date Sat, 12 Mar 2011 13:59:58 GMT
On 11/03/2011 08:29, Simone Tripodi wrote:
> Hi Francesco,
> I had a look at your final proposal and IMHO looks very fine. I
> suggest you can commit it without any side-issue then continue working
> on it if needed.
> Well done, I'd say ;)

Thanks Simone :-)
No one said anything against the patch, so I've committed it and closed 
the issue [1].

I hope it's fine.
Cheers.

> 2011/3/10 Francesco Chicchiriccò<ilgrosso@apache.org>:
>> Hi gents,
>> since a while we have in C3 cocoon-sax sources an
>> AbstractLinkRewriterTransformer that, inspired by C2.1 and C2.2
>> LinkRewriterTransformers, provides all means to intercept all links in the
>> source document and delegates any effective operation to an abstract
>> rewrite() method.
>>
>> The issue [1] is about making such transformer sitemap-compliant: of course,
>> an abstract class cannot be meant under such consideration.
>>
>> For this reason, based on some Simone's ideas, I wrote a
>> RegexpLinkRewriterTransformer extending the abstract class above and
>> providing a mean to define link rewriting based on standard java regular
>> expressions. Moreover, the "sitemap-compliancy" is shown by an extension of
>> current cocoon-sample. Ah, and finally running './it.sh' seems to be working
>> ;-)
>>
>> All that is, for the moment, included in a patch attached to [1]: do you see
>> any problem in committing such code? Do you think that such implementation
>> could be meaningful / useful? Do you see any possible update / extension?
>>
>> Thanks.
>>
>> [1] https://issues.apache.org/jira/browse/COCOON3-56
-- 
Apache Cocoon Committer and PMC Member

http://people.apache.org/~ilgrosso/


Mime
View raw message