Return-Path: Delivered-To: apmail-cocoon-dev-archive@www.apache.org Received: (qmail 20372 invoked from network); 13 Oct 2010 19:55:55 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 13 Oct 2010 19:55:55 -0000 Received: (qmail 2944 invoked by uid 500); 13 Oct 2010 19:55:55 -0000 Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org Received: (qmail 2845 invoked by uid 500); 13 Oct 2010 19:55:54 -0000 Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@cocoon.apache.org List-Id: Delivered-To: mailing list dev@cocoon.apache.org Received: (qmail 2838 invoked by uid 99); 13 Oct 2010 19:55:54 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Oct 2010 19:55:54 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Oct 2010 19:55:53 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o9DJtX7L023040 for ; Wed, 13 Oct 2010 19:55:33 GMT Message-ID: <19624935.130721286999733389.JavaMail.jira@thor> Date: Wed, 13 Oct 2010 15:55:33 -0400 (EDT) From: "Graham Triggs (JIRA)" To: dev@cocoon.apache.org Subject: [jira] Updated: (COCOON-2303) ThreadLocal in Sitemap EnvironmentHelper leaks on application undeployment In-Reply-To: <25897532.130701286999732890.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/COCOON-2303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Graham Triggs updated COCOON-2303: ---------------------------------- Attachment: sitemap.diff > ThreadLocal in Sitemap EnvironmentHelper leaks on application undeployment > -------------------------------------------------------------------------- > > Key: COCOON-2303 > URL: https://issues.apache.org/jira/browse/COCOON-2303 > Project: Cocoon > Issue Type: Bug > Components: - Components: Sitemap > Affects Versions: 2.2 > Reporter: Graham Triggs > Attachments: sitemap.diff > > > In sitemap-impl, there is a ThreadLocal that is used to store the EnvironmentStack. In the call to leaveProcessor, it pops an EnvironmentInfo off the stack. However, it doesn't clear the ThreadLocal when the stack is emptied. As such, there is a reference left over that can't be cleared normally when the application is undeployed. > Patch clears the environmentStack ThreadLocal when the stack is empty (it will get recreated anyway in the enterProcessor if it's required later). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.