cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefan Bodewig (JIRA)" <j...@apache.org>
Subject [jira] Created: (COCOON-2296) [PATCH] Make flowscript work with Commons JXPath 1.3
Date Thu, 12 Aug 2010 13:00:22 GMT
[PATCH] Make flowscript work with Commons JXPath 1.3
----------------------------------------------------

                 Key: COCOON-2296
                 URL: https://issues.apache.org/jira/browse/COCOON-2296
             Project: Cocoon
          Issue Type: Improvement
          Components: - Flowscript
    Affects Versions: 2.2, 2.2-dev (Current SVN)
            Reporter: Stefan Bodewig
            Priority: Minor


Apache Commons JXPath released almost exactly two years ago added a method

protected String escape(String)

to the NodePointer class (see http://svn.apache.org/viewvc/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/model/NodePointer.java?r1=618011&r2=618087
) this method's signature matches the one in org.apache.cocoon.components.flow.javascript.ScriptablePropertyPointer
which extends NodePointer - except that ScriptablePropertyPointer's version is private and
thus cannot override the one in NodePointer.

The method not only looks like yours, it also does the same thing (in a slightly different
way).

Given that JXPath 1.3 boasts a lot of bugfixes, users may want to upgrade.  The easiest fix
would be to upgrade to 1.3 in Cocoon, remove the method in ScriptablePropertyPointer and use
the base class version - this is what the attached patch does.

This issue has been found by Gump http://vmgump.apache.org/gump/public/cocoon/cocoon22-flowscript-impl/gump_work/build_cocoon_cocoon22-flowscript-impl.html
after I ensured flowscript doesn't see the latest version of Rhino.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message