From dev-return-102353-apmail-cocoon-dev-archive=cocoon.apache.org@cocoon.apache.org Mon Apr 12 19:52:12 2010 Return-Path: Delivered-To: apmail-cocoon-dev-archive@www.apache.org Received: (qmail 88802 invoked from network); 12 Apr 2010 19:52:12 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 12 Apr 2010 19:52:12 -0000 Received: (qmail 19313 invoked by uid 500); 12 Apr 2010 19:52:11 -0000 Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org Received: (qmail 19234 invoked by uid 500); 12 Apr 2010 19:52:11 -0000 Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@cocoon.apache.org List-Id: Delivered-To: mailing list dev@cocoon.apache.org Received: (qmail 19227 invoked by uid 99); 12 Apr 2010 19:52:11 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Apr 2010 19:52:11 +0000 X-ASF-Spam-Status: No, hits=-1270.1 required=10.0 tests=ALL_TRUSTED,AWL X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Apr 2010 19:52:10 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o3CJpma9000615 for ; Mon, 12 Apr 2010 15:51:48 -0400 (EDT) Message-ID: <16830466.5221271101908321.JavaMail.jira@thor> Date: Mon, 12 Apr 2010 15:51:48 -0400 (EDT) From: "Jasha Joachimsthal (JIRA)" To: dev@cocoon.apache.org Subject: [jira] Closed: (COCOON-2104) [PATCH] Add base URI fixup support to XIncludeTransformer In-Reply-To: <7279712.1185915052921.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/COCOON-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jasha Joachimsthal closed COCOON-2104. -------------------------------------- Fix version (Component): Parent values: Components: Pipeline(10228). Affects version (Component): Parent values: Components: Pipeline(10157). Fix Version/s: 2.1.12-dev (Current SVN) 2.2-dev (Current SVN) Resolution: Fixed Thanks Andrew for the patches > [PATCH] Add base URI fixup support to XIncludeTransformer > --------------------------------------------------------- > > Key: COCOON-2104 > URL: https://issues.apache.org/jira/browse/COCOON-2104 > Project: Cocoon > Issue Type: Bug > Components: * Cocoon Core > Affects Versions: 2.1.11, 2.2 > Reporter: Andrew Cave > Assignee: Jasha Joachimsthal > Priority: Minor > Fix For: 2.1.12-dev (Current SVN), 2.2-dev (Current SVN) > > Attachments: baseFixup-2.1-r561455.diff, baseFixup-2.2-r561499.diff > > > As discussed at [1], the XIncludeTransformer fails to perform the base URI fixup specified in the W3C's XInclude spec [2]. The spec says that the base URIs of elements do not change when passed through a conformant XInclude processor. Meaning, xml:base attributes must be added to the result set. The reason being that relative URIs in the included document should not break; this provides a mechanism to resolve them properly. > This patch results in the XIncludeTransformer adding xml:base attributes to top-level included elements. It does this only when the the base URI of the included element differs from the base URI of the parent element (meaning: for almost every case except where the included document is the current document). > The XIncludeTransformer's JUnit test is also updated by this patch to reflect the fact that the resulting XML file (xinclude-result-1.xml) has an xml:base attribute added. > [1] http://www.mail-archive.com/dev@cocoon.apache.org/msg52803.html > [2] http://www.w3.org/TR/xinclude/#base - The Base URI Fixup section of the W3C's XInclude specification -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira